chore: sync development into main - #9
Open
nicomiguelino wants to merge 1 commit into
Open
Conversation
- Set STAGE_EDGE_APP_ID and PRODUCTION_EDGE_APP_ID repo variables and pass them through to the initialize/update actions as edge_app_id - Drop id from screenly.yml and delete screenly_qc.yml since a single manifest is now used regardless of environment - Pin edge-apps-actions to a commit for now, since v26.9.0 can't be tagged there until a repo ruleset is adjusted
There was a problem hiding this comment.
🟢 Approval recommended
The changes are straightforward workflow/manifest updates aligned with the stated EDGE_APP_ID rollout and no verified functional issues were found in the modified regions.
Pull request overview
Syncs the EDGE_APP_ID rollout work from development into main by removing hardcoded manifest identifiers and wiring GitHub Actions deploy/initialize workflows to use environment-provided Edge App IDs.
Changes:
- Removes the hardcoded
idfromscreenly.ymland deletes the separatescreenly_qc.ymlmanifest. - Pins Screenly Edge Apps GitHub Actions to a specific commit SHA.
- Passes
edge_app_idinto update/initialize workflows viasecrets.EDGE_APP_IDwith environment-variable fallbacks.
File summaries
| File | Description |
|---|---|
screenly.yml |
Removes the embedded manifest id to support providing the Edge App ID externally. |
screenly_qc.yml |
Removes the QC-specific manifest file. |
.github/workflows/update-edge-app.yml |
Pins the update action and supplies edge_app_id from secrets/vars for stage and production deployments. |
.github/workflows/initialize-edge-app.yml |
Pins the initialize action and supplies edge_app_id based on selected environment. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs the EDGE_APP_ID rollout changes from
developmentintomain.