Skip to content

Use EDGE_APP_ID for stage and production deploys - #20

Merged
nicomiguelino merged 1 commit into
developmentfrom
feature/edge-app-id-env-var
Sep 4, 2026
Merged

Use EDGE_APP_ID for stage and production deploys#20
nicomiguelino merged 1 commit into
developmentfrom
feature/edge-app-id-env-var

Conversation

@nicomiguelino

Copy link
Copy Markdown
Contributor
  • Set STAGE_EDGE_APP_ID and PRODUCTION_EDGE_APP_ID repo variables and pass them through to the initialize/update actions as edge_app_id. An EDGE_APP_ID environment secret takes precedence when set, with these variables as the fallback until one exists, so switching to Environment secrets later needs no workflow changes.
  • Dropped id from screenly.yml and deleted screenly_qc.yml since a single manifest is now used regardless of environment.
  • Pinned edge-apps-actions to a commit for now, since v26.9.0 can't be tagged there until a repo ruleset is adjusted. Will switch to the tag once it exists.

- Set STAGE_EDGE_APP_ID and PRODUCTION_EDGE_APP_ID repo variables and pass them through to the initialize/update actions as edge_app_id
- Drop id from screenly.yml and delete screenly_qc.yml since a single manifest is now used regardless of environment
- Pin edge-apps-actions to a commit for now, since v26.9.0 can't be tagged there until a repo ruleset is adjusted
Copilot AI lite review requested due to automatic review settings September 4, 2026 00:20

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The workflows should fail fast with a clear error when neither the secret nor the fallback repo variable is set, to avoid confusing failures or mis-targeted deployments.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Updates the Screenly Edge App deployment workflows to target app IDs via workflow inputs (preferring an EDGE_APP_ID secret with repo-variable fallbacks), while consolidating to a single manifest across environments.

Changes:

  • Pass edge_app_id into the Screenly initialize and update GitHub Actions, using secrets.EDGE_APP_ID with stage/production repo-variable fallbacks.
  • Remove the manifest id from screenly.yml and delete screenly_qc.yml to rely on a single manifest for all environments.
  • Pin Screenly/edge-apps-actions to a specific commit SHA.
File summaries
File Description
screenly.yml Removes manifest id to avoid environment-specific manifest coupling.
screenly_qc.yml Deletes QC-specific manifest now that one manifest is used across environments.
.github/workflows/update-edge-app.yml Adds edge_app_id inputs for stage/production updates and pins the Screenly action SHA.
.github/workflows/initialize-edge-app.yml Adds edge_app_id input resolution for initialization and pins the Screenly action SHA.
Review details

Suppressed comments (1)

.github/workflows/update-edge-app.yml:40

  • edge_app_id will evaluate to a falsy value if neither secrets.EDGE_APP_ID nor vars.PRODUCTION_EDGE_APP_ID is set, which can lead to a confusing action failure (or potentially updating the wrong app if the action has a default). Add an explicit validation step so misconfiguration fails fast with a clear message.
          screenly_api_token: ${{ secrets.SCREENLY_API_TOKEN }}
          environment: production
          delete_missing_settings: 'true'
          edge_app_id: ${{ secrets.EDGE_APP_ID || vars.PRODUCTION_EDGE_APP_ID }}
  • Files reviewed: 4/4 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/initialize-edge-app.yml
Comment thread .github/workflows/update-edge-app.yml
@nicomiguelino
nicomiguelino merged commit 367d4da into development Sep 4, 2026
2 checks passed
@nicomiguelino
nicomiguelino deleted the feature/edge-app-id-env-var branch September 4, 2026 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants