chore: sync development into main - #16
Open
nicomiguelino wants to merge 2 commits into
Open
Conversation
* chore(deps): bump @screenly/edge-apps to 1.2.1 Removes the screen name from the app header (Screenly/edge-apps-library#56). * chore: regenerate screenshots for app-header fix Screenshot regeneration failed on the previous commit due to memory pressure on the dev machine. Re-ran cleanly and confirmed the header no longer shows the screen name.
nicomiguelino
marked this pull request as ready for review
July 23, 2026 03:37
- Set STAGE_EDGE_APP_ID and PRODUCTION_EDGE_APP_ID repo variables and pass them through to the initialize/update actions as edge_app_id - Drop id from screenly.yml and delete screenly_qc.yml since a single manifest is now used regardless of environment - Pin edge-apps-actions to a commit for now, since v26.9.0 can't be tagged there until a repo ruleset is adjusted
There was a problem hiding this comment.
🔵 Needs a closer look
It changes the deployment workflows and introduces a large dependency/lockfile update (toolchain changes) that should be validated by a human reviewer with CI/deploy context.
Pull request overview
This PR syncs the @screenly/edge-apps dependency bump from development into main, and adjusts manifests/workflows to align with the updated Edge Apps tooling and deployment configuration.
Changes:
- Bumps
@screenly/edge-appsfrom^1.0.0to^1.2.1and updatesbun.lockaccordingly. - Removes the
idfromscreenly.ymland deletesscreenly_qc.yml(QC manifest). - Pins Screenly GitHub Actions to a specific commit SHA and passes
edge_app_idexplicitly via secrets/vars.
File summaries
| File | Description |
|---|---|
screenly.yml |
Removes the embedded app id from the manifest. |
screenly_qc.yml |
Deletes the QC manifest file entirely. |
package.json |
Updates @screenly/edge-apps version to ^1.2.1. |
bun.lock |
Updates resolved dependency graph to match the new @screenly/edge-apps version. |
.github/workflows/update-edge-app.yml |
Pins the update action to a commit SHA and provides edge_app_id via secrets/vars. |
.github/workflows/initialize-edge-app.yml |
Pins the initialize action to a commit SHA and provides edge_app_id via secrets/vars with environment-based selection. |
Review details
- Files reviewed: 5/26 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
salmanfarisvp
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs the @screenly/edge-apps 1.2.1 dependency bump (removes the screen name from the app header) from development into main.