Fix: keep Screenly badge in the rail (avoid QR corner collision) - #18
Merged
Merged
Conversation
The 2026.7.2 adoption moved the badge to the kit's fixed bottom-right corner badge, but rss-reader already renders a QR "scan to read" lockup in the bottom-right — the two overlapped (caught on stage). Keep the badge in the top rail instead: stop prepending the kit's brand.css, restore the local `.brand` rail rule (the former .rail__brand styling), and only share the @font-face set. The bug fix from the adoption stays: the element is `.brand` (not the old .rail__brand), so the shared removeScreenlyBranding() still hides it on Screenly players. Verified: lint + 68 tests clean; built main.css has the rail `.brand` (no position:fixed) and the 9 canonical @font-face. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stage validation of the 2026.7.2 adoption caught the fixed corner
.brandbadge overlapping rss-reader's bottom-right QR "scan to read" lockup. rss-reader's badge was originally in the top rail, so restore that placement here.Changes
build.ts: prepend only the kit'sfonts.css(notbrand.css) — the fixed corner badge doesn't fit this layout.main.css: restore the local.brandrail rule (the former.rail__brandstyling).The adoption's bug fix stays: the badge element is
.brand(renamed from.rail__brand), so the sharedremoveScreenlyBranding()correctly hides it on Screenly players (it never did before). Fonts + the removal helper remain shared.Verification
lint+ 68 tests clean. Builtmain.csshas the rail.brand(noposition:fixed) + the 9 canonical@font-face. To be re-validated on stage.🤖 Generated with Claude Code