Skip to content

Fix: System UI brightness slider has no effect while KompaktX is running #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chadchad4423 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix: System UI brightness slider has no effect while KompaktX is running #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e60058d
Sync System UI brightness slider with KompaktX's overlay brightness
Aug 24, 2026
e3d1a29
Doesn't adopt/pin from an external SCREEN_BRIGHTNESS write while adap…
Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 32 additions & 3 deletions app/src/main/java/com/noti/restore/overlay/OverlayPanelManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,17 +129,38 @@ object OverlayPanelManager {
stripContext = context
loadSavedBrightness(context)

// Watch for system brightness changes and override with our target
// Watch for system brightness changes and adopt them as our new target, so the
// stock System UI slider (or any other writer of Settings.System.SCREEN_BRIGHTNESS)
// stays in sync with KompaktX's overlay instead of being immediately reverted by it.
//
// applyBrightness() below sets currentBrightnessTarget *before* writing
// Settings.System.SCREEN_BRIGHTNESS, so a change we triggered ourselves always finds
// sys == target here and is a no-op. Only a genuinely external write reaches the
// branch below, which is what lets this safely distinguish "someone else changed it"
// from "we just changed it" without an extra flag.
brightnessObserver = object : ContentObserver(handler) {
override fun onChange(selfChange: Boolean) {
val target = currentBrightnessTarget
if (target < 0) return
try {
// Don't fight Adaptive Brightness: an external write to SCREEN_BRIGHTNESS
// while the system is in automatic mode (e.g. Settings' own Display screen
// mirroring its live auto-brightness value into this setting) is not KompaktX
// being asked to sync anything — adopting it as a new target and pinning the
// overlay to it here would fight Adaptive Brightness the same way reverting
// did before this branch, just with a different stale-ish value.
if (isAdaptiveBrightnessOn(context.contentResolver)) return
val sys = Settings.System.getInt(context.contentResolver, Settings.System.SCREEN_BRIGHTNESS)
if (sys != target) {
Settings.System.putInt(context.contentResolver, Settings.System.SCREEN_BRIGHTNESS, target)
val screenVal = if (target <= 0) 0.001f else target / 255f
currentBrightnessTarget = sys
val screenVal = if (sys <= 0) 0.001f else sys / 255f
// Mirror applyBrightness()'s side effects so the externally-set value
// actually reaches the physical backlight (the overlay's screenBrightness
// param drives it, not Settings.System by itself), persists across a
// KompaktX process restart, and still applies above the lockscreen.
applyScreenBrightnessToView(brightnessOverlay, screenVal)
com.noti.restore.service.RecentsButtonService.applyAccessibilityBrightness(screenVal)
saveBrightness(context)
}
} catch (_: Exception) {}
}
Expand Down Expand Up @@ -2319,6 +2340,14 @@ object OverlayPanelManager {
} catch (_: Exception) {}
}

/** True when the system's own Adaptive Brightness is currently on. */
private fun isAdaptiveBrightnessOn(resolver: android.content.ContentResolver): Boolean {
return try {
Settings.System.getInt(resolver, Settings.System.SCREEN_BRIGHTNESS_MODE) ==
Settings.System.SCREEN_BRIGHTNESS_MODE_AUTOMATIC
} catch (_: Exception) { false }
}

/** Re-apply our brightness target after screen wake. Forces both Settings.System and overlay. */
fun reapplyBrightness() {
val ctx = stripContext ?: return
Expand Down