Repository navigation
Conversation
pid-j
changed the title
Owner
|
!format |
Owner
|
darn, does that not work here |
Owner
|
your implementation could be better anyway (it should be if the input isn't an array in general, not just specifically if it's null) but thx anyway |
Author
i just wanted to do the bare minimum to make it actually launch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the
_filterArrayfunction, passing anullvalue results in the function throwing an error due to not being able to access themapproperty. This only occurs in non-ReduxStore environments (such as packaged projects).This isn't the best solution, as the "Language Code <=> Name Conversions" section of the extension is made completely useless, but it's at least better than the project not loading.