Skip to content

Le bunch of changes - #10

Merged
ScratchFakemon merged 4 commits into
ScratchFakemon:Localefrom
pid-j:Locale
Sep 23, 2026
Merged

ScratchFakemon merged 4 commits into
ScratchFakemon:Localefrom
pid-j:Locale

Conversation

@pid-j

@pid-j pid-j commented Sep 22, 2026 •

Copy link
Copy Markdown

Resolves my comments:

  • Replace {} with Object.create(null) whenever possible to avoid getting dangerous values (e.g. prototype) (comment)
  • Checks if the arguments to the setter functions are actually Objects or other types since JSON.parse can accept other types (e.g. string, bool, number, array) (comment 1 · comment 2)
  • Only allow the translate block to return String-type values to avoid accessing dangerous properties (comment)

as well as a few other changes, e.g. decluttering code and fancy reduce magic

@ScratchFakemon
ScratchFakemon merged commit b557298 into ScratchFakemon:Locale Sep 23, 2026
4 checks passed
@ScratchFakemon

Copy link
Copy Markdown
Owner

tysm mister unpaid servant pigeon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants