Add ScoreSaber profile linking to team page#102
Closed
yabje wants to merge 6 commits into
Closed
Conversation
Qwasyx
suggested changes
Feb 23, 2026
Member
Qwasyx
left a comment
Qwasyx
left a comment
There was a problem hiding this comment.
Before we can accept this we need to be 100% sure this doesn't break the PC or Quest plugins team pages, they are somewhat sensitive to the specific json format.
| { platform: 'GitHub', url: teamMember.GitHub ? `https://github.com/${teamMember.GitHub}` : null, icon: 'fab fa-github', label: 'GitHub' } | ||
| ].filter((link) => link.url); | ||
|
|
||
| $: scoreSaberLink = `https://scoresaber.com/u/${teamMember.ScoreSaberID}`; |
Member
There was a problem hiding this comment.
We shouldn't statically create a link like this, requiring the links to be to scoresaber.com
Author
There was a problem hiding this comment.
this one is gone now, just only have the link that i also mentioned in the thing below
| {/each} | ||
| </div> | ||
| {/if} | ||
| <a href={scoreSaberLink} class="cursor-pointer"> |
Member
There was a problem hiding this comment.
if we already have the ScoreSaber id, we should just directly use the corresponding player links. That way everyone also has their correct color.
Author
There was a problem hiding this comment.
should be fixed with a /u/{scoresaberid} now
yabje
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Scoresaber profile links to the ScoreSaber Team page!
Please merge together with team page PR:
ScoreSaber/team#40
Might need testing if plugins survive