Repository navigation
Revert #396 (shader async compile): fails on phone - #397
Merged
Merged
Conversation
…)" Phone 2 test on 19 Nov showed this bundle is not usable: with the default 5 s compile cap backboardd crash-loops on a cold cache, and with the cap off no frame is ever presented. It was merged by mistake after that result.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #396. The phone 2 test recorded in that PR's last comment found a backboardd crash loop with the default 5 s compile cap and no frame with the cap disabled. It was merged by mistake today; this puts main back to the tree that boots. The branch
ios27/shader-cache-fixkeeps the work for a second attempt.