Repository navigation
feat(extensions): sign in to Scient Agent MCP servers from the Installed page - #1072
Draft
yaacovcorcos wants to merge 1 commit into
Draft
yaacovcorcos wants to merge 1 commit into
yaacovcorcos wants to merge 1 commit into
Conversation
…led page - With an agent that offers the mcp host command, the Installed page lists Scient Agent's MCP servers (Codex plugin servers included) from `mcp list`: connected with tool counts, needs sign-in, failed; file rows stay as the fallback and for disabled servers. - Sign in runs `mcp login <name>` in the sign-in's scope, returns the authorization URL, settles on completed/failed/early exit, then refreshes the inventory. - Older agents keep today's behavior and message.
Contributor
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Other scenariosAll 64 scenario measurements match All 64 scenario measurements
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Scient Agent's MCP servers, including the ones it imports from installed Codex plugins, now show their real status on the Installed page, and Sign in works for them. Before this, every Scient Agent server showed status "unknown", and Sign in failed with "Manage this MCP server's sign-in in Scient Agent."
ScientAgentPluginInventoryasks the agent's newmcphost command, but only when--runtime-infolists it inhostCommands.mcp list, so each row is connected (with its tool count), needs sign-in, failed or pending, and carriescanStartSignInand the CodexpluginId. If the listing fails, the page falls back to today's file rows. Disabled servers and ChatGPT-app rows are kept.readMcpServerrunsmcp list --server <name>.startMcpSignInrunsmcp login <name>inside the sign-in's scope. It returns the authorization URL, settles on completed, failed or an early exit, and then forces an inventory refresh.ProviderPluginCommandshares the executable lease and runtime-info read across commands, and addsrunScientAgentHostCommandandstartScientAgentHostProcess.Why
Without this, a Codex plugin server that needs sign-in (Cloudflare, for example) only printed an HTTP 401 inside the agent, and the app offered no way to sign in. This change reuses the provider-neutral sign-in seam that Codex already implements, instead of adding a second path.
Documentation Impact
Documentation impact: Dependent PR — ScientFactory/scient-agent ScientFactory/scient-agent#79 (adds the
mcphost command; it needs a Scient Agent release before this does anything)Platforms
Verification
pnpm exec vp test run src/scient/extensions/ScientAgentMcpInventory.test.ts src/scient/extensions/ScientAgentPluginInventory.test.ts src/scient/extensions/ProviderPluginCommand.test.ts(inapps/server): 10 passed.pnpm run typecheck(inapps/server): no errors.~/.codex.mcp listlists 9 servers in about 1 s. A real Cloudflare sign-in completed, and an open RPC conversation picked up the new sign-in.mcpcommand.Review
Review: pending. Draft until the agent PR merges and is released.