Repository navigation
feat(release-mirror): publish complete Stable and Beta update feeds - #77
Merged
Merged
Conversation
… feeds
The release mirror worker now copies each channel's whole electron-updater set
(channel manifests, macOS ZIPs and DMGs, NSIS EXE, AppImage, blockmaps) from the
desktop GitHub releases into the immutable scient-desktop/<tag>/ directories and
then promotes generic feeds at scient-desktop/updates/{stable,beta}/.
- Every manifest must match the release handoff's size and SHA-256; every file it
names must be a bare name the handoff lists with the same size, and must hash to
the manifest's SHA-512 while streaming (the last chunk is held back until it does).
- Channel manifests are written last, each as a compare-and-swap on the version
seen before asking GitHub, so a feed never names missing bytes and a slow run
cannot undo a newer promotion. Old objects are kept; nothing is redirected.
- The feed copy only re-points file URLs to ../../<tag>/<name> (resolved by
electron-updater against the feed) and adds releaseName/releaseNotes from the
release's Atom entry, as GitHub's provider showed them. Digests are untouched.
- Beta is discovered from the beta repository's releases feed, by version.
- C1: versioned objects stay one-year immutable; feed manifests are no-store.
- The mirror worker remains the only publisher; README has the deploy/verify runbook.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Deploying scientfactory-website with
|
| Latest commit: |
92c7512
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4d3be10d.scientfactory-website.pages.dev |
| Branch Preview URL: | https://claude-mirror-update-feed-20.scientfactory-website.pages.dev |
yaacovcorcos
marked this pull request as ready for review
November 16, 2026 20:42
5 tasks done
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extend the existing release-mirror worker (the single publisher) to copy complete Stable and Beta electron-updater feeds into immutable release directories before promoting per-platform channel manifests. Payloads and manifests are checked against the release handoff; updater payloads additionally match their manifest SHA-512. Relative URLs keep requests on Scient's mirror, preserve previous-version blockmap paths, and include release notes.
The separate desktop feed-default switch MUST NOT land before this worker is deployed, feeds are populated, and live verification succeeds. No production deployment is requested in this PR.
Documentation and source-version impact
Documentation impact: Updated — README.md deployment/cache/verification runbook; docs/architecture/desktop-downloads.md architecture. No app-help source/version change.
Validation
bun run checkCandidate efeae95. macOS arm64 local
bun run check: format, Astro/functions/events/mirror typechecks, generated-worker types, tests (211 passed, 2 skipped), static build and edge build passed. One existing deprecated navigator.platform hint. Five regression cases fail on the pre-fix implementation (existing-object digest mismatch, missing ZIP, missing blockmap, Stable/Beta rollback) and pass after the fix. Extra arm64 Linux/deb feed coverage added.Live C1 cache rules applied (ruleset
8356b52a036146aca8769c7e516967ec): download host only; immutable/scient-desktop/v*respects origin TTLs; HTTP 300–599 never stored; channel metadata/stable.json bypassed. A full v0.6.29 arm64 DMG request returnedHITand matched SHA-256c0f90ee1513e9c7d2282dd6851523f259935c68f9649926040d55c6abf430851; range 0–99 returned206, 100 bytes,HIT. Moving stable.json remainsno-store; repeated missing EXE requests are 404/DYNAMIC, never HIT. Worker/feed deployment is not performed: new updater metadata currently returns 404/DYNAMIC.Backend worker change, no new rendered UI; no human preview or native installed-app update was exercised. Signed macOS/Windows application, Linux installation, and real Worker streaming/R2 publication remain unqualified.
Quality Review
Codex's first pass confirmed three publication-guard defects: reused assets skipped SHA-512 checks; CAS did not reject a sequential stale source; manifest presence did not guarantee required payloads/blockmaps. All fixed in efeae95 with regression negative controls. Fresh Codex re-check: PASS at efeae95; all three findings closed, no new confirmed regressions. Reviewer independently passed 32 worker tests and mirror typecheck. Existing immutable-write/pointer-last implementation reused, no second publisher.
Integration Readiness Review
Source review passed at efeae95; local
bun run checkpassed at that head. Ready for maintainer review, not merged or deployed. Real Worker/R2 publication and native update qualification are still outstanding. No claim of signed macOS/Windows apply or Linux installation. The desktop client default switch remains draft until deployment verification. No automatic merge enabled.Deployment impact
Pages deployment does not deploy the mirror worker. After merge, an explicitly authorized operator deploys the worker from main, verifies Paid-plan limits, populates both channels, confirms cache/Range and SHA-512/size/noCache checks against the newly mirrored files, then qualifies the desktop switch #967. The narrow C1 cache policy above is already active independently; no worker or desktop feed change deployed. Old release objects remain immutable and retained.
Model/harness attribution: implementation from previous Claude session; independent review by Codex GPT-6.1 Sol; integration/verification through Scient.