Fix precompile and Core tests for Symbolics 7 / SymbolicUtils 4.46 - #48
Fix precompile and Core tests for Symbolics 7 / SymbolicUtils 4.46#48ChrisRackauckas-Claude wants to merge 4 commits into
Conversation
Disambiguate promote_symtype for expectation/probability operators, recurse through operator calls when collecting random variables, bind Symbolics for the precompile workload, and cap SymbolicUtils below 4.46 until MTK loads cleanly with newer SymbolicUtils. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Rebased onto main after #49 (OptimizationBBO ≥0.4.11, IntervalArithmetic ≥1.0.11, Symbolics 7.37 floors + DiscreteMeasures Ignore until reviewed by @ChrisRackauckas. |
464fc91 to
f0e47fa
Compare
IA 1.x rejects Base.intersect on intervals; Downgrade/main DiscreteMeasures tests hit ArgumentError on clamp_domain. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Follow-up: DiscreteMeasures OUQBase Downgrade still showed `Unreachable reached` on the Flood Problem test — investigating separately if it persists after this push. Ignore until reviewed by @ChrisRackauckas. |
…ests. IA 1.x empty intervals evaluate `∅_trv == ∅_trv` as false, so clamp_domain tests failed under both Sublibrary CI and Downgrade Sublibraries after switching to intersect_interval. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Follow-up: DiscreteMeasures Interval Ext tests now use `isequal` (IA 1.x empty intervals are not `==` even when both are `∅_trv`). Same failure was on Sublibrary CI and Downgrade Sublibraries. Ignore until reviewed by @ChrisRackauckas. |
Base isequal/== are inconclusive or false for decorated intervals in IA 1.x; isequal_interval is the supported comparison. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Follow-up: use |
|
Closing as superseded: already on master or replaced by later work. 🤖 Posted by an AI agent — harness: Claude Code, model: claude-opus-5[1m]. Chris asked for these closures directly. |
2 participants
Summary
SymbolicUtils.promote_symtypefor𝔼/ℙoperators and build operator terms withterminstead of rawTermconstruction.get_ordered_group_names.Symbolicsin the umbrella module so the precompile workload can expand@random_variables.SymbolicUtilsbelow 4.46 (MTK precompile fails with 4.46) and widenOrderedCollectionscompat in OUQBase.Test plan
GROUP=CorePkg.test()passed (Umbrella Load 5/5) with isolated depot after these changes.Made with Cursor