Skip to content

Fix Documentation build: CanonicalMoments SymbolicsExt precompile failure on Symbolics 7 #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisRackauckas merged 1 commit into from
Aug 26, 2026
Merged

Fix Documentation build: CanonicalMoments SymbolicsExt precompile failure on Symbolics 7 #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 11 additions & 15 deletions lib/CanonicalMoments/ext/SymbolicsExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
module SymbolicsExt
using Symbolics
import Symbolics: unwrap, wrap, array_term
using CanonicalMoments
using LinearAlgebra

@register_array_symbolic (alg::CanonicalMoments.EigvalSupportAlg)(M::AbstractMatrix{<:Real}) begin
size = (size(M)[1],)
Expand All @@ -14,26 +12,24 @@ end
eltype = eltype(M)
end

# `AbstractVecOrMat` is a `Union` alias, which `@register_array_symbolic` cannot
# introspect; `AbstractArray` covers both the vector and matrix cases.
@register_array_symbolic (alg::CanonicalMoments.EigvecWeightAlg)(
M::AbstractMatrix{<:Real},
λ::AbstractVecOrMat{<:Real},
λ::AbstractArray{<:Real},
) begin
size = size(M)
eltype = eltype(M)
end

function CanonicalMoments._companion_matrix(B::Vector{Num}, C::Vector{Num})
dv = -B
ndims = length(B)
ev = sqrt.(C[2:end]) # Probably use views here
_comp_mat_unwrapped = array_term(
SymTridiagonal,
unwrap.(dv),
unwrap.(ev);
eltype = Real,
size = (ndims, ndims),
)
return wrap(_comp_mat_unwrapped)
# Registering the companion matrix constructor keeps it lazy for symbolic inputs
# while deferring to the numeric implementation otherwise.
@register_array_symbolic CanonicalMoments._companion_matrix(
B::AbstractVector{<:Real},
C::AbstractVector{<:Real},
) begin
size = (length(B), length(B))
eltype = Real
end

end
Loading