Repository navigation
Add snapshot-based balanced POD for continuous-time LTI systems - #219
TommyDanMa wants to merge 1 commit into
Conversation
PR: #219 Reviewed head: 52f33cb Risk assessment
Review reportVERDICT: CHANGES Riskmedium-low (ML7: additive Blocking findings
Non-blocking findings
What I ran
What I did not verify
AUTHOR_GRADE: {"task":"feature","score":3,"difficulty":3,"rounds":1,"author_harness":"unknown","author_model":"unknown","note":"The balanced POD and analytic convergence tests pass, but supported operator inputs fail and a finite scalar projection can silently return an infinite pole."} Head link: 52f33cb 🤖 Posted by an AI agent — harness: codex-cli 0.170.0 · model: gpt-6.2-sol |
Summary
Adds snapshot-based Balanced Proper Orthogonal Decomposition (BPOD) for continuous-time linear time-invariant systems, using Rowley's (2005) direct primal/adjoint snapshot formulation.
Related to #11.
The new public function is:
It accepts already-weighted primal and adjoint snapshot factors, computes the SVD of
Y' * X, and constructs the balanced Petrov-Galerkin projectors and reduced system.The result reuses the existing
BalancedTruncationtype, containing reducedA,B,C,D, retained approximate Hankel singular values, and the left/right projectors.The implementation:
baltrunc.Float32,Float64, compatible mixed precision, and common sparse/banded matrix representations.Numerical validation
Tests cover:
Validation status
The full Core suite and documentation build remain blocked by the unrelated MethodOfLines 1.6 incompatibility documented in #216. PR #218 proposes a fix. The same DEIM failure was reproduced on the upstream baseline without these BPOD changes.
The complete documentation build, including final rendering and link checks, has therefore not been verified.
Scope and limitations
This PR implements the snapshot-based reduction core. The caller supplies weighted factors
XandY; snapshot generation, ODE integration, analytic tail correction, and ModelingToolkit integration are outside the scope.The dense interaction SVD may become expensive when snapshot counts are large. Finite-horizon and quadrature errors affect the reduced model, and stability is not guaranteed for approximate factors.
I would particularly welcome maintainer feedback on whether this low-level snapshot-factor API is the appropriate initial scope for #11, and whether automatic snapshot generation should be considered as a follow-up PR.