Retire unreachable symbolic compatibility ranges - #73
Merged
ChrisRackauckas merged 1 commit intoJul 22, 2026
Merged
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Member
Author
Post-creation scratchpad commentImplementation/evidence checkpoint for commit
The branch was prepared from the then-current |
ChrisRackauckas
marked this pull request as ready for review
July 22, 2026 20:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build_ratefuncsreturn contract while compiling rate functions through publicSymbolics.build_functionWhy these floors
ModelingToolkitBase 1 already requires SymbolicUtils 4.6+ and Symbolics 7.1.1+.
Consequently, the old SymbolicUtils 1/2/3 and Symbolics 5/6 declarations were
dead ranges rather than usable transition support. Catalyst 15 is also
incompatible with ModelingToolkitBase 1 because its Symbolics constraint stops
at major 6.
The SciML downgrade workflow selected the direct floors recorded here:
This is constraint normalization and public-API repair, not an age-based
retirement.
Public API changes inside the implementation
The implementation now consumes owner-exported
Symbolics.@variables,Symbolics.build_function,SymbolicUtils.substitute,SymbolicIndexingInterface.getname,RuntimeGeneratedFunctions.@RuntimeGeneratedFunction, andModelingToolkitBase.parameters. It no longer reaches throughSymbolicUtils.Code.toexpr,SymbolicUtils.scalarize,Symbolics.value,symbolic
.namefields, or method-table.mt.nameinternals.build_ratefuncsstill returns JuliaExprbodies as documented. An internalwrapper carries the compiled runtime-generated callable and the same expression
needed by RHS code generation. No FiniteStateProjection public name was added or
changed, so the existing rendered documentation remains accurate.
Validation
GROUP=Core: 58/58GROUP=QA: 20/20GROUP=Core Pkg.test(; allow_reresolve=false): 58/5818/18
precompiled; runtime and extension checks passed
byte-for-byte identical
git diff --check, public-owner scan, and TOML floor assertions passedThe canonical direct-floor Manifest remained unchanged at SHA-256
e66312cd36f422cd8cf33644040deb6eb1665efa0a52cde999263f36f7cb88e4.One exploratory whole-root
Pkg.precompile(; strict=true); Pkg.build()commandis explicitly non-authoritative and retained as a failed diagnostic. It cannot
root
Distributionsbecause that package is test-only under[extras]; buildwas not reached. The official locked Core run and the separate exact
Distributions/Rmath strict probe are the relevant validation paths.
Known pre-existing issue
The independent clean-main investigation found an intermittent randomized
SSRootfind normalization defect and opened
#72. It is outside this
patch. The final Core runs passed, and the fixed-RNG clean/candidate outputs were
byte-identical.
Project.tomlis already on unreleased 0.4.0. No version change is included;the pre-1.0 compatibility narrowing belongs in that minor release.