Move build files into pycode/memilio-simulation and update actions#1566
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1566 +/- ##
==========================================
- Coverage 97.47% 97.46% -0.02%
==========================================
Files 190 190
Lines 15966 15966
==========================================
- Hits 15563 15561 -2
- Misses 403 405 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I merged all duplicate install and download sections (unless I overlooked one) into one for each C++, Python, and general setup / cloning. I also fixed a lot of spurious warnings while fixing my own mistakes, so maybe ask for an additional proof-reader for the docs. |
annawendler
left a comment
There was a problem hiding this comment.
Thank you for these changes, this makes the installation more consistent and intuitive again! My comments are only regarding documentation.
Co-authored-by: annawendler <106674756+annawendler@users.noreply.github.com> Co-authored-by: reneSchm <49305466+reneSchm@users.noreply.github.com>
annawendler
left a comment
There was a problem hiding this comment.
I found one last typo but otherwise this looks good :D
Co-authored-by: annawendler <106674756+annawendler@users.noreply.github.com>
|
Thanks for your thorough review. I did not expect there to be that many doc changes, but I think this should make the installation easier to navigate. |

Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
If need be, add additional information and what the reviewer should look out for in particular:
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)