Add update, delete, add methods for absences#122
Open
Fermenade wants to merge 13 commits into
Open
Conversation
ghost
suggested changes
Apr 10, 2026
ghost
left a comment
There was a problem hiding this comment.
Unsafe parsing: In extractObjectByName, add a safety check for script.children[0].data. It will crash with a TypeError on empty script tags.
Error handling: Make the final throw more descriptive (e.g., "CSRF token object not found")
Timezones: Double-check if manual date-to-string conversion handles timezone offsets correctly to avoid shifts.
|
CSRF implementation is a necessary step, but its current stability is questionable. Fix the mentioned issues to meet the standard. We don't need more 'maybe-working' code in the core. |
Author
|
I'll take a look |
Author
|
Not sure how to do the type definition file stuff. Does anyone know? :) |
TheNoim
requested changes
Apr 15, 2026
Author
|
@TheNoim just wanna check in. Do you see anymore problems in the code? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
here is some code that let's an user add, update and delete absences.
Changed some function names for clarity.
Added datatype representing the return type from untis
Added quality of life date time function
Added functions for add, remove and update operation