Skip to content

Migrated many schemas to strict validation - #6191

Open
Vessel9817 wants to merge 56 commits into
SchemaStore:masterfrom
Vessel9817:strict
Open

Vessel9817 wants to merge 56 commits into
SchemaStore:masterfrom
Vessel9817:strict

Conversation

@Vessel9817

@Vessel9817 Vessel9817 commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Each commit modifies a single file, or otherwise applies a single patch. This may be exempt if there is a circular dependency.

Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
As per the [latest docs](https://github.com/SAP-archive/cloud-s4-sdk-pipeline/blob/476e60dc8bdb7989d03e9755f22d0b3096934b5e/configuration.md#artifactdeployment), the requirement for the nonexistent property `repository` was replaced with a requirement for `mavenRepository` and/or `npmRepository`.

Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Made stricter, many, many type unions.

Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Made many, many type unions stricter.

Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Applied a logical xor to `env` and `value`, requiring at least one be present.

Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Applied a logical xor to `env` and `value`, requiring at least one be present.

Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Applied a logical xor to `env` and `value`, requiring at least one be present.

Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Applied a logical xor to `env` and `value`, requiring at least one be present.

Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Patches a logic bug introduced in 4d0eb4b

Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Patches a logic bug introduced in 4ab5335

Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
@madskristensen

Copy link
Copy Markdown
Contributor

This has a merge conflict.

Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>

@Vessel9817 Vessel9817 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again! Just to check, do you prefer the individual PR strategy, or are lump PRs like this easier to work with?

Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>

@Vessel9817 Vessel9817 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only ask, because it'd be really easy to:

  • cherry-pick a combined PR like this into separate PRs; or
  • merge multiple PRs into one grand PR.

As it's not exactly commonplace to be fiddling with a large quantity of unrelated schemas all at once, I would like to hear your thoughts so that we can prevent future misunderstandings and simplify your workflow. I'd happily go as far as to update the contributing guidelines to reflect your preferences, intended for large changes.

Frankly, lacking the experience, I can't imagine reviewing all these commits. I can't thank you both enough for your continued time and dedication.

Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Patches a bug introduced in 639279b

Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
@hyperupcall

Copy link
Copy Markdown
Member

@Vessel9817 Do you think that it would be difficult to rework these and have separate PRs for each "type" of change"? For example, one or a few PR for very minor changes that won't break things, like adding "type": "object" and similar. These will be larger and we can merge these with little worry.

And then, having separate PRs for larger things that aren't automatic changes or have the potential to change behavior. Those would be separate and these PRs should naturally be smaller.

@hyperupcall

Copy link
Copy Markdown
Member

And thank you for your comment and concerns

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants