Migrated expo-*.json to draft-07 - #5973
Open
Vessel9817 wants to merge 12 commits into
Open
Vessel9817 wants to merge 12 commits into
Vessel9817 wants to merge 12 commits into
Conversation
Vessel9817
commented
Jul 15, 2026
Vessel9817
commented
Contributor
- Migrated from draft-04 to draft-07
- Enabled strict validation
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Extrapolated plugin usage from [plugin docs][docs] [docs]: https://docs.expo.dev/config-plugins/plugins/ Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Contributor
|
This has a merge conflict. |
hyperupcall
requested changes
Sep 9, 2026
hyperupcall
left a comment
hyperupcall
left a comment
Member
There was a problem hiding this comment.
Thanks! Had a few comments.
| }, | ||
| "mimeType": { | ||
| "type": "string" | ||
| "anyOf": [ |
Member
There was a problem hiding this comment.
Normally, i would suggest that the object by itself and within items be extracted into a definitions since they appear to the the same. But, since this schema is likely autogenerated, it is probably better to preserve it as-is like you did.
| }, | ||
| "platforms": { | ||
| "description": "Platforms that your project explicitly supports. If not specified, it defaults to `[\"ios\", \"android\"]`.", | ||
| "example": ["ios", "android", "web"], |
Member
There was a problem hiding this comment.
Should these examples be preserved?
| }, | ||
| {} | ||
| ], | ||
| "minItems": 2, |
Member
There was a problem hiding this comment.
Here so the minItems and additionalItems come from somewhere? Unsure if this change is to be consistent with other Expo schemas, or its a unique change. Saw this transformation in a few other places too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.