Conversation
|
Thanks for the PR! This section of the codebase is owned by @domdomegg, @bogini, @sarahdeaton, and @ant-kurt - if they write a comment saying "LGTM" then it will be merged. |
…uffix Azure DevOps repo URLs (https://dev.azure.com/org/project/_git/repo) and AWS CodeCommit URLs never end in .git, but Claude Code's docs confirm the suffix is optional for the git marketplace source. Drop the overconstrained \.git$ pattern from extraKnownMarketplaces and blockedMarketplaces so these hosts validate, matching strictKnownMarketplaces which already has no such restriction.
9b9f850 to
4253ba5
Compare
|
@domdomegg can you take a look at this? |
|
Sorry for the delay here; only now am catching up on a huge backlog of PRs 😅 |
|
LGTM |
|
There was an issue merging, maybe try again domdomegg. Details |
|
LGTM |
|
There was an issue merging, maybe try again domdomegg. Details |
|
Is there something i need to do to have it merged? |
|
LGTM |
|
There was an issue merging, maybe try again domdomegg. Details |
|
Heads-up: I've included this change in my v2.1.251 sync PR (#6273), with credit to you. I deferred to this PR in my previous sync (#6131) rather than duplicating it, but since it's been sitting a while I folded it in so the fix isn't waiting on mine. Your test fixtures and the two negative-test removals are carried over as-is. If this one merges first, the overlap is harmless — the change is identical. For what it's worth, I re-verified it against plugin-marketplaces#git-repositories: "The |
Summary
extraKnownMarketplacesandblockedMarketplacesconstrain thegitsource'surlfield with a\.git$pattern. This rejects valid marketplace URLs from git hosts that don't use a.gitsuffix, such as Azure DevOps (https://dev.azure.com/org/project/_git/repo) and AWS CodeCommit.Per the official docs (Create and distribute a plugin marketplace):
\.git$pattern from bothextraKnownMarketplacesandblockedMarketplaces'sgitsourceurlfield. This also brings them in line withstrictKnownMarketplaces, which already has no such pattern on its equivalent field.urlfield descriptions, per CONTRIBUTING.md's convention of using<description>\n<url>.marketplace-host-pattern.jsonandmanaged-settings.json..gitsuffix is invalid" — that assumption no longer holds per the docs, and keeping them would fail Ajv's negative-test validation now that the pattern is gone.Test plan
node ./cli.js check --schema-name=claude-code-settings.jsonpassesnode ./cli.js coverage --schema-name=claude-code-settings.jsonpasses (8/8, strict mode)