Skip to content

feat(claude-code-settings): allow git marketplace URLs without .git suffix - #5874

Open
esp0 wants to merge 1 commit into
SchemaStore:masterfrom
esp0:claude-code-settings-azure-devops-git-url
Open

esp0 wants to merge 1 commit into
SchemaStore:masterfrom
esp0:claude-code-settings-azure-devops-git-url

Conversation

@esp0

@esp0 esp0 commented Jul 1, 2026

Copy link
Copy Markdown

Summary

extraKnownMarketplaces and blockedMarketplaces constrain the git source's url field with a \.git$ pattern. This rejects valid marketplace URLs from git hosts that don't use a .git suffix, such as Azure DevOps (https://dev.azure.com/org/project/_git/repo) and AWS CodeCommit.

Per the official docs (Create and distribute a plugin marketplace):

Full git repository URL (https:// or git@). The .git suffix is optional, so Azure DevOps and AWS CodeCommit URLs without the suffix work

  • Removed the \.git$ pattern from both extraKnownMarketplaces and blockedMarketplaces's git source url field. This also brings them in line with strictKnownMarketplaces, which already has no such pattern on its equivalent field.
  • Added the documentation anchor link to both url field descriptions, per CONTRIBUTING.md's convention of using <description>\n<url>.
  • Added positive test coverage (Azure DevOps URLs) to marketplace-host-pattern.json and managed-settings.json.
  • Removed two negative test fixtures that asserted "missing .git suffix is invalid" — that assumption no longer holds per the docs, and keeping them would fail Ajv's negative-test validation now that the pattern is gone.

Test plan

  • node ./cli.js check --schema-name=claude-code-settings.json passes
  • node ./cli.js coverage --schema-name=claude-code-settings.json passes (8/8, strict mode)

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Thanks for the PR!

This section of the codebase is owned by @domdomegg, @bogini, @sarahdeaton, and @ant-kurt - if they write a comment saying "LGTM" then it will be merged.

…uffix

Azure DevOps repo URLs (https://dev.azure.com/org/project/_git/repo) and
AWS CodeCommit URLs never end in .git, but Claude Code's docs confirm the
suffix is optional for the git marketplace source. Drop the overconstrained
\.git$ pattern from extraKnownMarketplaces and blockedMarketplaces so these
hosts validate, matching strictKnownMarketplaces which already has no such
restriction.
@esp0

esp0 commented Jul 27, 2026

Copy link
Copy Markdown
Author

@domdomegg can you take a look at this?

@domdomegg

Copy link
Copy Markdown
Contributor

Sorry for the delay here; only now am catching up on a huge backlog of PRs 😅

@domdomegg

Copy link
Copy Markdown
Contributor

LGTM

@domdomegg domdomegg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

Copy link
Copy Markdown
Contributor

There was an issue merging, maybe try again domdomegg. Details

@domdomegg

Copy link
Copy Markdown
Contributor

LGTM

@github-actions

Copy link
Copy Markdown
Contributor

There was an issue merging, maybe try again domdomegg. Details

@esp0

esp0 commented Aug 6, 2026

Copy link
Copy Markdown
Author

Is there something i need to do to have it merged?

@domdomegg

Copy link
Copy Markdown
Contributor

LGTM

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

There was an issue merging, maybe try again domdomegg. Details

@miteshashar

Copy link
Copy Markdown
Contributor

Heads-up: I've included this change in my v2.1.251 sync PR (#6273), with credit to you.

I deferred to this PR in my previous sync (#6131) rather than duplicating it, but since it's been sitting a while I folded it in so the fix isn't waiting on mine. Your test fixtures and the two negative-test removals are carried over as-is. If this one merges first, the overlap is harmless — the change is identical.

For what it's worth, I re-verified it against plugin-marketplaces#git-repositories: "The .git suffix is optional, so Azure DevOps and AWS CodeCommit URLs without the suffix work." strictKnownMarketplaces's git variant already had no .git$ pattern, so the schema was inconsistent with itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants