Skip to content

perf(tickets): reduce close workflow latency #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sayrix merged 1 commit into from
Jul 1, 2026
Merged

perf(tickets): reduce close workflow latency #613

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions src/features/tickets/close-workflow.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,11 @@ async function closeTicket(
const { ticket, ticketType } = closable;
const closer = getInteractionUser(interaction);
const normalizedReason = normalizeCloseReason(app, reason);
const claimedBy = ticket.claimedBy;
const closeUsersPromise = Promise.all([
app.client.api.users.get(ticket.createdBy).catch(() => null),
claimedBy ? app.client.api.users.get(claimedBy).catch(() => null) : Promise.resolve(null)
]);

// Mark the ticket as closed immediately so repeated button presses or `/close`
// attempts during transcript generation do not start duplicate close flows.
Expand All @@ -232,13 +237,16 @@ async function closeTicket(
// Preserve the original ticket message while preventing new actions.
await disableTicketActionButtons(app, ticket.channelId, ticket.creationMessageId);
});
await status.update(app.LL.tickets.close.status.updating_access());
void status.update(app.LL.tickets.close.status.updating_access());
await removeClosedTicketParticipantAccess(app, ticket.channelId, ticket.createdBy, invitedUserIds);
}

const transcriptJob = app.config.tickets.close.createTranscript
? await startTranscriptJob(app, ticket.channelId, {
onStatus: (content) => status.update(content)
// Progress is informational; Discord interaction edits must not gate transcript work.
onStatus: (content) => {
void status.update(content);
}
})
: null;

Expand All @@ -254,10 +262,7 @@ async function closeTicket(
await status.update(app.LL.tickets.close.status.transcript_still_processing());
}

const [opener, claimer] = await Promise.all([
app.client.api.users.get(ticket.createdBy).catch(() => null),
ticket.claimedBy ? app.client.api.users.get(ticket.claimedBy).catch(() => null) : Promise.resolve(null)
]);
const [opener, claimer] = await closeUsersPromise;
const openerUsername = opener?.username ?? ticket.createdBy;
const closeMessageTokens = {
channelId: ticket.channelId,
Expand Down Expand Up @@ -290,7 +295,7 @@ async function closeTicket(
});

if (app.config.tickets.close.deleteChannelOnClose && app.config.tickets.close.dmUserOnClose) {
await status.update(app.LL.tickets.close.status.sending_close_confirmation());
void status.update(app.LL.tickets.close.status.sending_close_confirmation());
await sendCloseDm(app, ticket.createdBy, ticketType, closeMessageTokens);
}

Expand All @@ -316,7 +321,7 @@ async function closeTicket(
closeTasks.push(sendCloseDm(app, ticket.createdBy, ticketType, closeMessageTokens));
}

await status.update(
void status.update(
app.config.tickets.close.dmUserOnClose
? app.LL.tickets.close.status.sending_close_updates()
: app.LL.tickets.close.status.posting_close_summary()
Expand Down
Loading