fix!: unclash right mouse button in crop tool#562
Open
RobertMueller2 wants to merge 3 commits into
Open
Conversation
RobertMueller2
changed the title
Adds tool dismiss/commit buttons. Introduces handle_dismissed method for tools. The buttons only really work for crop and text right now. Change text so Esc used handle_dismissed, enter is already available for commit.
Closes: Satty-org#560 Addresses complaint in Satty-org#470 When using right mouse button for actions, in crop it may be counter-intuitive that right click resets crop. For now, add Ctrl modifier to the right click. This is experimental because in the future tool related bindings/shortcut may be configurable. PR builds on Satty-org#561, because that one offers a mouse-only way to apply and reset crop.
RobertMueller2
force-pushed
the
crop_rightclick_fix
branch
from
ed2b7a5 to
77eec54
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #560
Addresses complaint in #470
When using right mouse button for actions, in crop it may be counter-intuitive that right click resets crop.
For now, add Ctrl modifier to the right click. This is experimental because in the future tool related bindings/shortcut may become configurable.
Also add Ctrl+Left click to finish crop editing.
PR builds on #561, because that one offers a mouse-only way to apply and reset crop.