Prepare Liquid2 merge into dev - #366
Open
BullishNode wants to merge 89 commits into
Open
Conversation
* Paymentalist / check_bolt11_mrh --------- Co-authored-by: Philippe Lamy <philippe@philippelamy.ca>
…p-testing-script Feature/create reverse swap testing script
Bump ELEMENTS_VERSION to v23.2.5
(cherry picked from commit 5d034a4)
(cherry picked from commit cc55bd9)
(cherry picked from commit 850deb7)
* Testing watching from spender * Support for multiple spending wallets
…v-ready # Conflicts: # cyphernodeconf_docker/templates/bitcoin/walletnotify.sh # proxy_docker/app/script/manage_missed_conf.sh
BullishNode
marked this pull request as ready for review
July 24, 2026 18:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prepare
features/liquid2for merge intodev, includingfeatures/elgetaddrinfo.This branch brings the Liquid/Elements integration forward onto current
dev, keeps Bitcoin behavior compatible, hardens the Liquid request/runtime paths, and adds repeatable merge-readiness test coverage.Merge strategy
The strategy was compatibility-first:
dev.getaddressinfoendpoint because the Liquid watch flow benefits from a first-class way to inspect owned Elements addresses.Commit-level rationale
elements_getaddressinfo endpointRationale:
features/elgetaddrinfo.Strategy:
watcherlevel, matching the address-inspection use case.Make Liquid integration merge-readyRationale:
dev.Strategy:
watching_assetid, matching the fresh-install schema and allowing the same address/callback pair to be watched for different assets.vout, amount, and asset come from the selected watched output.Harden Elements RPC request handlingRationale:
Strategy:
jq --argand--argjsonso request values cannot alter the JSON-RPC method or structure.Harden Liquid watch and Paymentalist runtimeRationale:
Strategy:
Add Liquid2 merge-readiness test harnessRationale:
devschema to the candidate Liquid2 schema.Strategy:
contrib/liquid2-merge-readiness/local-static.shfor local static checks, Elements shell regressions, Paymentalist Rust checks, and Docker image builds.contrib/liquid2-merge-readiness/migration-dev-to-liquid2.shto create an isolated current-devdatabase, run candidate migrations twice, and verify Bitcoin data survives while Liquid tables/indexes are present.contrib/liquid2-merge-readiness/staging-server-live-smoke.shfor live deployed-stack smoke coverage against Bitcoin Core and Elements without broadcasting spends.contrib/liquid2-merge-readiness/gatekeeper-auth-matrix.shto test every deployed Gatekeeper action against no token, invalid token, and all configured API ids.Validation
Passed:
contrib/liquid2-merge-readiness/local-static.shcontrib/liquid2-merge-readiness/migration-dev-to-liquid2.shcontrib/liquid2-merge-readiness/gatekeeper-auth-matrix.shcontrib/liquid2-merge-readiness/staging-server-live-smoke.shproxy_docker/app/tests/test-watches.shproxy_docker/app/tests/test-elements-manage-missed.shproxy_docker/app/tests/test-manage-missed.shLive staging validation covered:
Notes for reviewers