Don't include magnetism parameters in pure python models#734
Open
pkienzle wants to merge 1 commit into
Open
Conversation
sara-mokhtari
approved these changes
May 23, 2026
Contributor
|
I ran the pure python models with the GUI, it is now possible to compute their 1D curves and it seems to be working fine, thank you @pkienzle. Here's an example of curves of an octahedron with no truncation and a tetrahedron with truncation = 0.5 obtained via the GUI. 2D plots are loaded but as we know orientational averaging is not yet supported for Python models (#695). We would be happy to work on this whenever it fits your schedule. I also opened PR #735 for a documentation fix. If everything looks good, I suggest merging this PR first, updating #735 accordingly, and then merging it as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes sasmodels portion of #732
The full fix requires a change to sasview as well.
An alternative solution is to remove the "sld" type from the sld parameters in the pure python models, and update modelinfo.parse_parameter so that it doesn't infer it from the name. This can be done without changing the existing sasview code.