Fix HID++ battery voltage out-of-range handling#516
Merged
Sapd merged 1 commit intoSapd:masterfrom May 5, 2026
Merged
Conversation
Add minimum voltage check in HIDPPDevice::requestBatteryHIDPP to return BATTERY_UNAVAILABLE when measured voltage is below the device's calibrated minimum. This prevents spline interpolation on invalid readings from offline or disconnected headsets. All HID++ battery calibrations store voltages in descending order, so calibration.voltages.back() correctly returns the minimum valid voltage. Affected devices: - Logitech G633/G635/G733/G933/G935 (LOGITECH_G633 calibration) - Logitech G533 (LOGITECH_G533 calibration) - Logitech G535 (LOGITECH_G535 calibration) - Logitech G PRO Series (LOGITECH_GPRO calibration)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
All HID++ battery calibrations store voltages in descending order, so
calibration.voltages.back()correctly returns the minimum valid voltage.Affected Devices