Fix settings window overflow at larger text/accessibility scaling - #115
Open
wi-ry wants to merge 2 commits into
Open
Fix settings window overflow at larger text/accessibility scaling#115wi-ry wants to merge 2 commits into
wi-ry wants to merge 2 commits into
Conversation
- Replace LockedWindowBounds with resizable WindowBounds + min size so the settings window can grow to fit larger text/accessibility scaling instead of clipping content - Split header/close button out of the scrollable region so they stay fixed while settings content scrolls independently - Add custom scrollbar styling scoped to .scrollableContent, overriding the global thumb rule which was collapsing the scrollbar to 0 width - Fix Preview component using a hardcoded 352px width, causing inconsistent right-side spacing; now measures container width via ResizeObserver so it scales with the rest of the layout - Tune body/scrollableContent padding for consistent spacing around the scrollbar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Users with Windows accessibility text scaling set above 100% (e.g. 150%)
found the settings window content overflowed the fixed window bounds,
with no way to resize the window or scroll to reach clipped controls.
Changes
LockedWindowBoundswith a standardWindowBounds, keeping the original initial size but allowing thewindow to grow and setting a sensible minimum size.
(drag region + close button) stays fixed while the settings content
below it scrolls independently, instead of the whole window scrolling
together.
*::-webkit-scrollbar-thumbrule (
border: 4px solid transparent+background-clip: content-box)was silently collapsing the new scrollbar to 0px width. Added a
scoped override for
.scrollableContentso the thumb renderscorrectly, with padding tuned for consistent spacing on both sides.
(
Preview.jsx) used a hardcoded352pxwidth, which caused it tomisalign with the rest of the settings once the window became
resizable. It now measures its container via
ResizeObserverandscales responsively instead.
iv2runtime/(IgniteView's generated runtimeoutput), which shouldn't be tracked.
Testing
content no longer clips, scrollbar appears only when needed.
ratio or alignment with other settings rows.
Screenshots
At 100% font size:
At 150% font size:
At 225% font size:
Fixes #114