Skip to content

Godot: isolate reviewed playback candidate and runtime evidence - #143

Merged
Samfa12-tech merged 1 commit into
mainfrom
codex/godot-runtime-acceptance-20261017
Oct 17, 2026
Merged

Samfa12-tech merged 1 commit into
mainfrom
codex/godot-runtime-acceptance-20261017

Conversation

@Samfa12-tech

Copy link
Copy Markdown
Owner

Prepared Godot playback can use the wrong section origin, combine fullmix and layers, block cold loading, or truncate a finite native arrangement ending. This candidate transplants the independently reviewed addon changes from PR127 (9609876ea44c69751631ad8f399f88ab66d5eff8) onto released main 63c89d4687e7e8aea26287297ed83badcef6bc63, preserving released DAW/web/DJ/Core bytes.

It also adds bounded rendered-scene diagnostics that correlate frame gaps, conductor/player clocks, SFX requests and engine-bus PCM. A source-only CI mode retains its isolated project/logs and defers ZIP packaging. Family governance now distinguishes candidate addon1.3.0 from public1.2.0.

Validation on Godot4.6.3 Windows/WASAPI:

  • All15 existing source/runtime/editor stages and12 Node process/shutdown guard tests passed; governance and six-surface sound-profile contract passed.
  • Fresh Core0.3 fullmix/layers in both player modes and retained48k native arranged reference preserve complete decoded PCM, tails and natural endings. Silence and final-frame truncation controls reject.
  • Current installed DAW0.6.59 export is44.1k; observedWASAPI48k addon output matches a concurrent plain-player resampler control exactly. Corrected live-player telemetry stays within11ms of wall time in both addon modes, with original anchors preserved.
  • All150ms clock,33.333ms frame, one60Hz-frame cold-load and2ms warm-Play limits remain unchanged. Startup first-draw gaps and deliberate180ms delays fail whole-run frame bounds; historical intermittent failures and Unicode-NUL diagnostics remain open. Failed setup/rate/telemetry attempts remain retained.

See addons/pocket_chordsmith/docs/REPRESENTATIVE_RUNTIME_CHECKPOINT_2026-10-17.md for the implemented/tested/published/blocked ledger and exact evidence scopes. This draft requests independent source review. No addon release ZIP, merge or public upload is part of this checkpoint. Human listening/performance acceptance and final4.6 listing metadata remain release holds; Sam uploads the Store ZIP himself, with no Store API access or duplicate submission.

@Samfa12-tech
Samfa12-tech merged commit 2fb2f49 into main Oct 17, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant