Repository navigation
Godot: isolate reviewed playback candidate and runtime evidence - #143
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepared Godot playback can use the wrong section origin, combine fullmix and layers, block cold loading, or truncate a finite native arrangement ending. This candidate transplants the independently reviewed addon changes from PR127 (
9609876ea44c69751631ad8f399f88ab66d5eff8) onto released main63c89d4687e7e8aea26287297ed83badcef6bc63, preserving released DAW/web/DJ/Core bytes.It also adds bounded rendered-scene diagnostics that correlate frame gaps, conductor/player clocks, SFX requests and engine-bus PCM. A source-only CI mode retains its isolated project/logs and defers ZIP packaging. Family governance now distinguishes candidate addon1.3.0 from public1.2.0.
Validation on Godot4.6.3 Windows/WASAPI:
See
addons/pocket_chordsmith/docs/REPRESENTATIVE_RUNTIME_CHECKPOINT_2026-10-17.mdfor the implemented/tested/published/blocked ledger and exact evidence scopes. This draft requests independent source review. No addon release ZIP, merge or public upload is part of this checkpoint. Human listening/performance acceptance and final4.6 listing metadata remain release holds; Sam uploads the Store ZIP himself, with no Store API access or duplicate submission.