Configuration phase support for Velocity#124
Conversation
| // Declined/failed is valid and should be allowed, server owner decides whether they get kicked | ||
| if (status != PlayerResourcePackStatusEvent.Status.ACCEPTED && status != PlayerResourcePackStatusEvent.Status.DOWNLOADED && !kick) { | ||
| plugin.log("Sent player '%s' plugin message downstream to '%s' for status '%s'", player.getUsername(), currentServer.get().getServerInfo().getName(), status.name()); | ||
| plugin.log("Sent player '%s' plugin message downstream to '%s' for status '%s'", player.getUsername(), currentServer.getServerInfo().getName(), status.name()); |
There was a problem hiding this comment.
This is broken when using configuration phase (sendPluginMessage).
We need to somehow update the Paper and Sponge submodules to listen to this channel on configuration phase.
There was a problem hiding this comment.
I will work on refactoring the event handling and push to this PR
There was a problem hiding this comment.
It is not possible to support configuration stage status events. Paper doesn't even have an event for configuration resource pack statuses and player object doesn't exist during config phase.
…ses. Additionally implement a temporary fix for translations on 26.1+ servers.
SamB440
left a comment
SamB440
left a comment
There was a problem hiding this comment.
I have tested on both Paper and Sponge behind a velocity proxy and it now works as expected.
The caveat on Paper is that they don't support checking permissions in configuration stage, nor do they support calling the resource pack event in configuration phase. Therefore, no event will be called, and the workaround is that we remove the player from waiting list on join if they have bypass permission.
2 participants
PR for #74