Bugfix/contact network visualization - #87
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Feature: Network Graph Enhancements & Interactivity
📖 Description
This Pull Request significantly upgrades the Network Edge map view, focusing on improved visualization, reliable collision handling, and deep interactivity. The changes address node rendering limitations, introduce intuitive click actions, and ensure the entire graph always scales perfectly to the user's screen.
✨ Key Features & Enhancements
1. Auto-Scaling & Layout Pre-calculation
2. Deep Node Interactivity
event.defaultPreventedchecks to cleanly differentiate between a user dragging a node (to play with physics) and a deliberate, short click.3. Visual & State Refinements
32pxto80px).🐛 Bug Fixes
contact-[id],connector-[name],company-[name]) to prevent identical names (e.g., "Mom") from merging into single, incorrectly linked nodes.d3-zoomcrash occurring in headless test environments (which lack full SVG DOM support) by explicitly defining the.extent()parameter in the zoom configuration.NetworkGraph.test.jsxto correctly mock theuseToastcontext, ensuring clean test passes.🧪 Verification
npm run lintcompletes with zero warnings or errors.npm run testpasses (38/38 tests successfully passing).