Time to ae#92
Open
samussiah wants to merge 5 commits into
Open
Conversation
Contributor
|
|
Contributor
|
Charts look great, @samussiah! I'm going to work on a PR that refactors the metadata workflow soon - see SafetyGraphics/safetyGraphics#637 for details. Will use this PR for testing once I've got that set up. |
Contributor
|
Looks good, but a bit more customization is needed to fully parameterize. Let's tackle it in a future release. |
Contributor
|
@samussiah We should pick this back up again and try to finalize as time allows. |
There was a problem hiding this comment.
Copilot reviewed 4 out of 13 changed files in this pull request and generated no comments.
Files not reviewed (9)
- DESCRIPTION: Language not supported
- NAMESPACE: Language not supported
- R/meta.R: Language not supported
- R/mod_timeToAE.R: Language not supported
- R/timeToAE.R: Language not supported
- data-raw/makeMeta.R: Language not supported
- data-raw/meta_timeToAE.csv: Language not supported
- man/meta_timeToAE.Rd: Language not supported
- man/timeToAE.Rd: Language not supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #83
Hang tight on the PR - I added a new metadata file but I haven't incorporated it in the workflow. Also need to document the new functions.