Skip to content

Add stringent unit tests for legacy ciphers (TEA, RedPike, AveMaria)#2

Merged
SWORDIntel merged 2 commits into
mainfrom
codex/test-and-upgrade-cryptographic-functions-97ts5u
May 8, 2026
Merged

Add stringent unit tests for legacy ciphers (TEA, RedPike, AveMaria)#2
SWORDIntel merged 2 commits into
mainfrom
codex/test-and-upgrade-cryptographic-functions-97ts5u

Conversation

@SWORDIntel
Copy link
Copy Markdown
Owner

Motivation

  • Increase regression coverage for recently added legacy ciphers and catch subtle implementation regressions early.
  • Verify determinism and reversible behavior of AveMariaCipher across cycle and fixed table modes.
  • Provide an explicit test path for KASUMI presence so the suite documents whether the symbol is implemented or should be skipped.

Description

  • Added tests/unit/test_new_ciphers.py which includes a 256-iteration randomized roundtrip matrix for TEA and RedPike.
  • Added deterministic/roundtrip differentiation checks for AveMariaCipher ensuring cycle and fixed outputs differ and both decrypt correctly.
  • Added a passthrough safety test that ensures malformed or unknown AveMaria token groups remain unchanged on decrypt.
  • Added a conditional check that validates the KASUMI symbol when present and otherwise emits an explicit pytest.skip documenting current implementation status.

Testing

  • Ran python -m pytest -q tests/unit/test_new_ciphers.py tests/unit/test_ave_maria_cipher.py tests/unit/test_legacy_ciphers.py.
  • Result: 15 passed, 1 skipped (all new tests passed or skipped as intended).

Codex Task

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d695f6315e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tests/unit/test_legacy_ciphers.py
@SWORDIntel SWORDIntel merged commit 07dc299 into main May 8, 2026
0 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant