Feat/micro ask perm - #344
Merged
Merged
Conversation
frakdp
approved these changes
Dec 18, 2025
frakdp
left a comment
frakdp
left a comment
Contributor
There was a problem hiding this comment.
lgtm, the code follows permissions that where done before so the code is pretty straight forward, good testing also.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#345
PR Description
This PR adds microphone permission handling for the Voice Confirmation switch in the DangerModePreferences tab of the profile screen. When the switch is enabled, a popup now requests microphone access from the Android device.
To support this, I updated the ViewModel and the preference state, and adapted the related tests accordingly.