Feat/touch confirmation - #343
Merged
Merged
Conversation
The button will be used for the call or sms confirmation but it is fully modular so it can be used for other thing as needed.
The button will be used for the call or sms confirmation but it is fully modular so it can be used for other thing as needed.
…feat/dangermode-preferences # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
Add exclusive options for call and sms.
Add robustness against crash
…feat/automatic-dangermode # Conflicts: # app/src/androidTest/java/com/github/warnastrophy/e2e/EndToEndM3Test.kt
Fix useless check for manual activation of danger mode.
Fix flacky tests and danger mode view model nto working properly
…feat/automatic-dangermode # Conflicts: # app/src/main/java/com/github/warnastrophy/core/ui/features/dashboard/DangerModeCard.kt
Fix DangerModeCardViewModel.kt because it made a test flaky with Jacoco.
Add touch confirmation screen in the main composable and DangerModeOrchestrator.kt logic.
…feat/touch-confirmation # Conflicts: # app/src/main/java/com/github/warnastrophy/core/data/service/DangerModeOrchestrator.kt
ssidimoh694
requested changes
Dec 18, 2025
ssidimoh694
left a comment
ssidimoh694
left a comment
Contributor
There was a problem hiding this comment.
Hey ! Good job ! Just some point to think about. look at in code comments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR follows #318 and integrates the touch confirmation popup for the danger mode
It is just some small changes to orchestrator and call into the main composable