Skip to content

Refactor/small improvements - #335

Merged
ssidimoh694 merged 14 commits into
mainfrom
refactor/small-improvements
Dec 18, 2025
Merged

Refactor/small improvements#335
ssidimoh694 merged 14 commits into
mainfrom
refactor/small-improvements

Conversation

@ssidimoh694

@ssidimoh694 ssidimoh694 commented Dec 18, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

#337, #338, #342, #346
Fix search bar clear bug; small Danger Mode UI refactor; filter latest news by article URL

Description

  • Fix: resolve an issue where the search bar clear button did not remove the text or close the suggestions dropdown.
  • Refactor: adjust DangerModeCard UI (reduced spacing, added downward arrow for extra options) and update related tests to match the new layout.
  • Refactor: show only hazards that have an article URL in the "latest news" feed to avoid empty/non-article entries.
  • Tests: update and extend instrumented tests (MapScreen) to cover the search clear behavior and adapted danger card changes.

Was written by ChatGPT

@ssidimoh694 ssidimoh694 self-assigned this Dec 18, 2025
@ssidimoh694 ssidimoh694 added the enhancement New feature or request label Dec 18, 2025
@ssidimoh694 ssidimoh694 added this to the M3 milestone Dec 18, 2025
@ssidimoh694 ssidimoh694 linked an issue Dec 18, 2025 that may be closed by this pull request
Display only hazard with an article URL #338
Closed
@ssidimoh694 ssidimoh694 linked an issue Dec 18, 2025 that may be closed by this pull request
Improve DangerModeCard so that it expends when click on downward arrow #342
Closed
@Valink16
Valink16 self-requested a review December 18, 2025 04:07
Valink16
Valink16 requested changes Dec 18, 2025
View reviewed changes

@Valink16 Valink16 left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fixes

Valink16
Valink16 approved these changes Dec 18, 2025
View reviewed changes

@Valink16 Valink16 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ssidimoh694
ssidimoh694 requested a review from Valink16 December 18, 2025 05:41
@sonarqubecloud

sonarqubecloud Bot commented Dec 18, 2025

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
78.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@ssidimoh694
ssidimoh694 merged commit db1abdf into main Dec 18, 2025
1 of 3 checks passed
@ssidimoh694
ssidimoh694 deleted the refactor/small-improvements branch December 18, 2025 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Valink16 Valink16 Awaiting requested review from Valink16

Assignees

@ssidimoh694 ssidimoh694

Labels

enhancement New feature or request

Projects

None yet

Milestone

M3

Development

Successfully merging this pull request may close these issues.

Improve DangerModeCard so that it expends when click on downward arrow Display only hazard with an article URL

4 participants

@ssidimoh694 @Valink16 @eightysix-86 @ssidimoto