Feature/microphone autorisation - #319
Closed
ssidimoh694 wants to merge 22 commits into
Closed
ssidimoh694 wants to merge 22 commits into
ssidimoh694 wants to merge 22 commits into
Conversation
adapt test for hybrid, local and remote repository. adapt test for preferenceScreen
fix initialization error of userPreferenceRepository
ssidimoh694
force-pushed
the
feature/microphone-autorisation
branch
from
December 15, 2025 19:01
beb0f0f to
f55f2f6
Compare
frakdp
self-requested a review
December 17, 2025 17:53
frakdp
requested changes
Dec 17, 2025
frakdp
left a comment
frakdp
left a comment
Contributor
There was a problem hiding this comment.
Small changes required, the rest is a lgtm. Good job !
| val automaticSms = data?.get(FIELD_AUTOMATIC_SMS) as? Boolean ?: false | ||
| val automaticCalls = data?.get(FIELD_AUTOMATIC_CALLS) as? Boolean ?: false | ||
| val darkMode = data?.get(FIELD_DARK_MODE) as? Boolean ?: false | ||
| val microphoneAcess = data?.get(FIELD_MICROPHONE_ACCESS) as? Boolean ?: false |
|
|
||
|
|
||
| <string name="danger_mode_microphone_access_title">Microphone Access</string> | ||
| <string name="danger_mode_microphone_access_description">To use voice confirmation for emergency actions, the app needs access to your device\'s microphone. Please grant microphone permission in your device settings.</string> |
Contributor
There was a problem hiding this comment.
No need for the second phrase because the switch will show the confirmation popup, so the user won't need to go to the device settings.
Contributor
Author
|
Confusion with other team mate. This PR is not relevant anymore. More details in individual retrospective |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#320
Title: Add microphone permission and voice communication preference; update repositories and tests
Summary:
Added support for microphone permission required by the new voice communication screen. This change introduces a new preference field for microphone access, wires it through the profile UI, updates repositories to persist/sync the new field, and adapts tests accordingly.
What changed:
setMicrophoneAccessAPI in repositories.HybridUserPreferencesRepository, remote implementation).Profile/ voice screen).microphoneAccessreads/writes and sync behavior (app/src/test/.../UserPreferencesRepositoryRemoteTest.ktand related tests).Testing:
setMicrophoneAccesscalls and mapping ofmicrophoneAccessvalues.Notes for reviewers:
false.This PR description was generated by chat GPT