Skip to content

Various small fixes and SonarQube issues resolving #330

Description

@eightysix-86

Objective

Fix navigation and UI inconsistencies related to Danger Mode and Activities screens, align terminology by renaming Emergency Card to Health Card, and resolve all remaining SonarQube issues.

Description

Navigation issues currently prevent users from navigating back from the Danger Mode edit screen and the Activities management flow. Additionally, the top app bar title remains incorrectly set to “Dashboard” across multiple screens. To ensure consistency across the app, the Emergency Card terminology must be updated to Health Card. Finally, all reported SonarQube issues must be resolved to improve maintainability, readability, and long-term code quality.

Requirements

  • Fix back navigation and update the top app bar title dynamically in:

    • AddActivity
    • EditActivity
    • ActivityListScreen
  • Replace all occurrences of “Emergency Card” with “Health Card” in UI text, resources, and references.

  • Resolve all 42 SonarQube issues, including:

    • Code smells
    • Minor bugs
    • Naming and readability issues
  • Ensure fixes do not introduce regressions or behavior changes.

Testing

  • Verify back navigation works correctly from Danger Mode edit and Activities screens.
  • Confirm correct top bar titles are displayed on all affected screens.
  • Validate that “Health Card” is consistently used across the UI and codebase.
  • Re-run SonarQube analysis and ensure zero remaining issues.
  • Update and ensure previous tests fit the new version of the code

No activity

Activity on this issue will appear here.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingrefactoringRefactoring of previous code

Type

Projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions