Repository navigation
Include trait demand in away assignment events - #318
Merged
netniV merged 1 commit intoOct 4, 2026
Merged
Conversation
Adds officer_traits, critical_trait_scores, success_chance, critical_success_chance, max_critical_success_chance, key_stat, max_assignable_officers and the attack/defense/health weights, all from the AwayAssignmentInstance the event already parses. On a fresh offer critical_trait_scores is [] and the chances are 0 until officers are assigned. The chance fields are in the de-dup hash, so an assignment re-emits when they change. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
netniV
approved these changes
Oct 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #295. Adds the fields a crew planner needs to decide which officers and traits an away assignment wants. They come from the same
AwayAssignmentInstancetheaway_assignmentevent already parses. No config/TOML changes, the event name is unchanged, and the new keys are additive only, so existing receivers are unaffected.What changes
New flat keys on
away_assignment:officer_traits:[{tid, max_level}], the traits the assignment asks for.critical_trait_scores:[{tid, score}]sorted by tid, the assigned crew's current score per asked trait.success_chance,critical_success_chance,max_critical_success_chancekey_stat(0 unassigned, 1 attack, 2 defense, 3 health),max_assignable_officersattack_weight,defense_weight,health_weightNotes
critical_trait_scoresis[]andsuccess_chance/critical_success_chanceare 0 until officers are assigned.Verified
Windows client build 267, mod built from
dev+ this change (FileVersion 1.1.9.2), against a logging sync target: the login dump carried 9 assignments, all with non-emptyofficer_traits; battle, ship and job sync unaffected. An earlier capture (12 assignments) showed fresh offers (state 1) with emptycritical_trait_scoresand 0 chances, and started missions (state 2) with the scores and chances filled in alongside the existing fields. macOS not tested.Checks
🤖 Generated with Claude Code