Repository navigation
Restore battle log and ship sync for the current client (build 267) - #315
Merged
netniV merged 1 commit intoOct 1, 2026
Merged
Conversation
Client build 267 (2026-09-29) delivers battle result headers as entity group 219 (BattleResultHeadersResponse) and owned ships as group 251 (PlayerShipsResponse) instead of the Json group. Implement the 219 processor and add a 251 processor, sharing helpers with the Json handlers. Add the client's EntityGroup values 242-252, and declare only the proto fields that are read. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
netniV
approved these changes
Sep 30, 2026
netniV
left a comment
Collaborator
There was a problem hiding this comment.
Don't really see anything wrong here, but as it's sync and affects both STFC:Data and SpocksClub (among others), I'm gonna tag @lightbull-stfc and @ChronoXNL for a review. Would take Jess too but I don't think she uses GitHub like we do :)
This was referenced Oct 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since client build 267 (2026-09-29), battle logs and ships stop syncing. The client now sends battle result headers as entity group 219 (
BattleResultHeadersResponse) and owned ships as group 251 (PlayerShipsResponse) instead of in the Json group. The 219 processor was a stub and there was no case for 251, so both were dropped.This implements the 219 processor and adds a 251 processor. The emitted
battlelogandshipevents are unchanged.Fixes #314
What changes
processors::battle_result_headersparses group 219; the de-dupe/enqueue/persist logic moves into a sharedqueue_battle_idsthat the Json path also calls.processors::player_shipsparses group 251 into a sharedsync_ships. The Json handlers stay as thin wrappers over the same helpers and are behaviour-preserving; say if you'd rather I delete them. The dispatcherShipscase is gated byships.EntityGroup.hand the protoTypeenum gain values 242-252. OnlyShipsis used and live-verified; the other names come from the client's enum.JournalHeaderProto,BattleResultHeadersResponse,PlayerShipData,PlayerShipsResponse) are declared with only the fields that are read; happy to swap for regenerated full messages if you have them. The names are the client's own class names.Verified
Windows client build 267, mod 1.1.9.beta.1 + this change:
Overlaps with #295 in
processors; I'll rebase whichever lands second.Checks
🤖 Generated with Claude Code