Skip to content

Repair mission HUD visibility overrides for the current client - #296

Draft
Guffawaffle wants to merge 3 commits into
STFC-Mod:devfrom
Guffawaffle:fix/mission-hud-hooks
Draft

Guffawaffle wants to merge 3 commits into
STFC-Mod:devfrom
Guffawaffle:fix/mission-hud-hooks

Conversation

@Guffawaffle

@Guffawaffle Guffawaffle commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor

The current client removed MissionsHudViewController.UpdateButtons, so mission HUD visibility overrides no longer install. Resolve the five current lifecycle/setup methods, preserve their native calls and Boolean arguments, then apply explicit visibility choices for Q's Trials, Field Training, Outposts and Missions. Retire the removed Daily Goals control and correct the examples to auto, always and never.

Following #313, the existing default-enabled [patches].missionhudtweakshooks switch controls installation independently of feature values. Register all four supported buttons and reread each mode inside the callbacks. Validate complete managed signatures, distinct detour targets, compatible instance fields and storage bounds before installation; a partial detour failure leaves installed callbacks passing through without overrides. This branch retains TOML-driven behavior; live controls and immediate Auto restoration follow in #297.

Validation: Windows release build and all 11 example TOMLs pass. Three independent semantic lanes reviewed the exact candidate. Static Windows 270 native extents cover all five detour overwrite windows. Earlier Windows player testing used an integration build and confirmed HUD/Haven transitions; it does not qualify this exact candidate. Exact-candidate game smoke and macOS native extent/execution evidence remain outstanding. CI is started after publishing, without waiting for its results.

@Guffawaffle

Guffawaffle commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor Author

Hook/feature alignment follow-up for #313

Follow-up to #313: keep hook installation independent of feature enablement, with default-enabled compatibility switches under [patches] and feature checks inside the installed hooks.

Reconcile the HUD lifecycle repair with #313's independent [patches].missionhudtweakshooks. This branch still filters out Auto buttons at startup and returns without installing when no overrides are configured. Preserve every supported button definition and decide behavior from the current [ui].hud_q_trials, hud_field_training, hud_outposts, and hud_missions settings during hook execution. Retain native lifecycle calls and partial-install safeguards. Update this HUD parent first, then propagate it into #297 alongside that branch's separate #282 dependency.

Implemented in 0121a6f. All four supported buttons register under the existing independent missionhudtweakshooks switch; callbacks reread current modes and preserve native work. Complete signatures, field layout and distinct targets are validated before installation; partial installation remains inert. Exact Windows release build, all 11 TOMLs and three independent review lanes passed; CI is queued. Native game/Mac qualification remains open. Next: propagate this parent and corrected #282 into #297.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant