Repository navigation
Lay the config persistence foundation for runtime mod settings - #278
Closed
Guffawaffle wants to merge 20 commits into
Closed
Guffawaffle wants to merge 20 commits into
Guffawaffle wants to merge 20 commits into
Conversation
Guffawaffle
marked this pull request as ready for review
September 12, 2026 00:07
Contributor
Author
|
Closing in favor of a narrower rewrite based on the lessons from this implementation. The branch is retained as a reference for code, tests, and review evidence. The replacement will focus on established config paths, typed TOML encoding, same-file save coordination, and the agreed shutdown behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lays the persistence groundwork for mod settings that can be changed while the game is running.
The foundation has three layers:
Windows F10 remains a force-close path independent of Unity: it cancels queued saves and allows active work up to 500 ms to finish before terminating. It closes immediately when there is no active save supervisor. A separate native deadline thread enforces the grace period without joining writers or requiring another Unity update. The normal shutdown coordinator applies to the game's quit lifecycle, including window close. The host uses the existing Update dispatcher and validates the build261 Windows x64 quit method before enabling runtime registration. macOS startup transactions are supported; runtime registration remains unavailable until its lifecycle seam is validated.
Startup user-config creation is create-only, and generated runtime-vars output uses checked replacement. The preserving TOML editor and the first mod-owned settings control follow separately on a child branch. Runtime consumers will reuse this service; none ship in this foundation. PR267's JSON state work remains independent.
The service supports up to four destinations/workers, 32 retained tickets and 32 MiB of snapshot capacity. It rejects ambiguous destination/lock aliases. On Windows, supported inherited permissions are retained; ambiguous legacy security descriptors and unsupported inherited ACL forms are rejected before staging rather than migrated by a save.
Validation:
The implementation and tests document platform support, permission compatibility and filesystem recovery limits. Result presentation, targeted TOML editing and macOS runtime lifecycle support remain follow-on work.