Skip to content

fix: resolve package version from source tree metadata#77

Merged
SSobol77 merged 2 commits into
mainfrom
fix/source-tree-version-resolution
May 16, 2026
Merged

fix: resolve package version from source tree metadata#77
SSobol77 merged 2 commits into
mainfrom
fix/source-tree-version-resolution

Conversation

@SSobol77
Copy link
Copy Markdown
Owner

Maintenance fix for source-tree version resolution after v0.2.0 preparation.

Scope:

  • resolve ecli.version from pyproject.toml when running from a source checkout
  • preserve installed-package fallback via importlib.metadata.version("ecli-editor")
  • preserve local fallback "0.0.0+local"
  • add tests for source-tree, installed-package, malformed pyproject, missing metadata, non-string version, and fallback behavior

Why:

  • local source-tree execution must report the same version as pyproject.toml
  • tests must not accidentally depend on stale installed package metadata from .venv/site-packages

Not included:

  • no pyproject.toml version change
  • no release tag rewrite
  • no release workflow change
  • no CLI/TUI behavior change
  • no package artifacts

Validation:

  • PYTHONPATH=src python3 -m pytest tests/test_smoke.py -v
  • PYTHONPATH=src python3 -m pytest tests/test_version_resolution.py -v
  • PYTHONPATH=src python3 -m pytest tests/services -v
  • PYTHONPATH=src python3 -m pytest tests/characterization -v
  • PYTHONPATH=src python3 -m pytest tests/ui -v
  • PYTHONPATH=src python3 -m pytest tests/cli -v
  • PYTHONPATH=src python3 -m compileall src
  • ruff check src tests
  • ruff format --check src tests
  • ./scripts/check-log-invariant.sh
  • git diff --check

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 16, 2026

Important

Review skipped

Auto reviews are disabled on this repository. To trigger a review, include @coderabbitai review in the PR description. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e43e542f-282e-4eb1-95e4-d4d59a92e3b4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/source-tree-version-resolution

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

@SSobol77 SSobol77 merged commit 5e750e1 into main May 16, 2026
5 checks passed
@SSobol77 SSobol77 deleted the fix/source-tree-version-resolution branch May 16, 2026 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant