馃摑 Link the ADRs to the relevant SSW rules - #633
Merged
Conversation
Only the SQL exceptions ADR referenced ssw.com.au/rules. Reviewing all 17 against the rules site found 29 relevant rules that weren't linked anywhere. Each ADR now names its most relevant rule inline in Decision Outcome and lists the rest under Links, matching what #630 did for the SQL exceptions ADR. Where an ADR disagrees with a published rule, it says so. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Code review on the previous commit found ten problems with the citations. Two rules had been archived by SSW. Checking for HTTP 200 didn't catch it, because archived rules still serve a 200 and only show a banner on the page. Both now point at their live successors. Three findings shared one cause: a paragraph of new reasoning about the repository pattern added to an ADR accepted in 2023. The ADR log promises its entries are immutable, so that paragraph is gone and the rule is left as a plain entry under Links. The rest were overstated or misread claims: the string-length rule relocates constraints rather than dropping them, TypedResults checks the declared codes rather than whether the code is the right one, the NSwag ADR cited a rule that now leads with Scalar, and one rule title was truncated because its YAML title spans two lines. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
danielmackay
marked this pull request as ready for review
July 28, 2026 01:56
AntPolkanov
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
鉁忥笍 Follow-up to #630, which linked one ADR to its SSW rule. This does the same sweep across the rest of the log.
Reading all 17 ADRs against ssw.com.au/rules turned up 29 relevant rules that weren't referenced anywhere. It also turned up 10 gaps where the rules site either has nothing on the topic or is now out of date. Those gaps are tracked separately in the SAW backlog (SSWConsulting/SSW.SAW.General#39 through #48) and aren't touched here.
鉁忥笍 Every ADR in
docs/adrnow points at the SSW rules behind its decision, following the shape already set by20241118-produce-useful-sql-server-exceptions.md:## Decision Outcomenaming the most relevant rule## Linkssection listing the restThree ADRs deliberately disagree with a published rule, and now say so instead of linking silently:
None of the decisions, options, or pros and cons were changed. Docs only, no code.
Verification: all 29 slugs were checked against the
SSW.Rules.Contentrepo tree, and every URL returns HTTP 200 from ssw.com.au.鉁忥笍 No, solo with Claude Code.