Skip to content

[autobackport: sssd-2-10] Add AD certificate authentication test - #9483

Merged
spoore1 merged 1 commit into
SSSD:sssd-2-10from
sssd-bot:SSSD-sssd-backport-pr8453-to-sssd-2-10
Oct 16, 2026
Merged

spoore1 merged 1 commit into
SSSD:sssd-2-10from
sssd-bot:SSSD-sssd-backport-pr8453-to-sssd-2-10

Conversation

@sssd-bot

Copy link
Copy Markdown
Contributor

This is an automatic backport of PR#8453 Add AD certificate authentication test to branch sssd-2-10, created by @krishnavema.

Caution

@krishnavema The patches did not apply cleanly. It is necessary to resolve conflicts before merging this pull request. Commits that introduced conflict are marked with CONFLICT!.

You can push changes to this pull request

git remote add sssd-bot git@github.com:sssd-bot/sssd.git
git fetch sssd-bot refs/heads/SSSD-sssd-backport-pr8453-to-sssd-2-10
git checkout SSSD-sssd-backport-pr8453-to-sssd-2-10
git push sssd-bot SSSD-sssd-backport-pr8453-to-sssd-2-10 --force

Original commits
ebc2664 - tests: add AD smart card certificate authentication test

Backported commits

  • 01ffc90 - CONFLICT! tests: add AD smart card certificate authentication test

Conflicting Files Information (check for deleted and re-added files)

  • CONFLICT! tests: add AD smart card certificate authentication test
On branch SSSD-sssd-backport-pr8453-to-sssd-2-10
You are currently cherry-picking commit ebc266470.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   src/tests/system/tests/test_ad.py

no changes added to commit (use "git add" and/or "git commit -a")

Original Pull Request Body

Adds a system test verifying that an AD user can authenticate using a certificate on a virtual smart card.

@krishnavema
krishnavema force-pushed the SSSD-sssd-backport-pr8453-to-sssd-2-10 branch from 1a33b50 to fd1ca83 Compare October 16, 2026 08:13
@krishnavema
krishnavema marked this pull request as ready for review October 16, 2026 08:15

@sumit-bose sumit-bose left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

backport matches original, ACK.

bye,
Sumit

@sumit-bose sumit-bose added the no-backport This should go to target branch only. label Oct 16, 2026

@spoore1 spoore1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

(cherry picked from commit ebc2664)
Reviewed-by: Scott Poore <spoore@redhat.com>
Reviewed-by: Sumit Bose <sbose@redhat.com>
@sssd-bot

Copy link
Copy Markdown
Contributor Author

The pull request was accepted by @spoore1 with the following PR CI status:


🟢 rpm-build:centos-stream-10-x86_64:upstream (success)
🟢 testing-farm:centos-stream-10-x86_64:upstream (success)
🟢 ci / prepare (success)
🟢 ci / system (centos-10) (success)
🟢 Static code analysis / files-changed (success)
🟢 Static code analysis / pre-commit (success)
🟢 Static code analysis / python-system-tests (success)


There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging.

@sssd-bot
sssd-bot force-pushed the SSSD-sssd-backport-pr8453-to-sssd-2-10 branch from fd1ca83 to 70ab106 Compare October 16, 2026 13:54
@spoore1
spoore1 merged commit f229acb into SSSD:sssd-2-10 Oct 16, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Accepted no-backport This should go to target branch only.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants