Repository navigation
[autobackport: sssd-2-9] ldap: pwd_expire_policy_warn does not overwrite errors - #9443
Merged
alexey-tikhonov merged 4 commits intoOct 13, 2026
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| time.sleep(3) | ||
| log2 = client.fs.read(client.sssd.logs.pam) | ||
| assert "indicators: 0" in log2, "String `indicators: 0` not found in logs!" | ||
| <<<<<<< HEAD |
| rc, _, stdout, _ = client.auth.parametrize(method).password_with_output("user1", "Secret123") | ||
| assert rc == 0, "User 'user1' login failed!" | ||
| assert "Your password will expire in " in stdout, "Password expiration warning not generated!" | ||
| <<<<<<< HEAD |
sssd-bot
force-pushed
the
SSSD-sssd-backport-pr9393-to-sssd-2-9
branch
from
October 12, 2026 17:37
0f97e06 to
75c3f74
Compare
alexey-tikhonov
added
no-backport
sssd-bot
force-pushed
the
SSSD-sssd-backport-pr9393-to-sssd-2-9
branch
from
October 12, 2026 17:39
75c3f74 to
ff3b98d
Compare
sumit-bose
force-pushed
the
SSSD-sssd-backport-pr9393-to-sssd-2-9
branch
2 times, most recently
from
October 13, 2026 07:53
a3c66a2 to
c16c56d
Compare
sumit-bose
marked this pull request as ready for review
October 13, 2026 08:38
alexey-tikhonov
approved these changes
Oct 13, 2026
Make sure the 'pwd_expire_policy_warn' access check does not overwrite any access denied or other errors. :fixes: CVE-2026-92821 Reviewed-by: Alexey Tikhonov <atikhono@redhat.com> Reviewed-by: Dan Lavu <dlavu@redhat.com> (cherry picked from commit e83a29c)
Verify fix for CVE-2026-92821 and make sure the 'pwd_expire_policy_warn' access check does not overwrite any access denied or other errors. Reviewed-by: Alexey Tikhonov <atikhono@redhat.com> Reviewed-by: Dan Lavu <dlavu@redhat.com> (cherry picked from commit 57d6818)
If the shadow scheme is used to determine if a password is expired or not the user currently does not see a message that the password is expired if the shadow attribute sp_lstchg is missing or 0. With this patch the message is shown in this case as well. Reviewed-by: Alexey Tikhonov <atikhono@redhat.com> Reviewed-by: Dan Lavu <dlavu@redhat.com> (cherry picked from commit 1a258a4)
Verify fix for CVE-2026-92821 and make sure the 'pwd_expire_policy_warn' access check does not overwrite any access denied or other errors. Reviewed-by: Alexey Tikhonov <atikhono@redhat.com> Reviewed-by: Dan Lavu <dlavu@redhat.com> (cherry picked from commit aaaea88)
Contributor
Author
|
The pull request was accepted by @alexey-tikhonov with the following PR CI status: 🟢 rpm-build:centos-stream-9-x86_64:upstream (success) There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging. |
sssd-bot
force-pushed
the
SSSD-sssd-backport-pr9393-to-sssd-2-9
branch
from
October 13, 2026 10:21
c16c56d to
6641224
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of PR#9393 ldap: pwd_expire_policy_warn does not overwrite errors to branch sssd-2-9, created by @sumit-bose.
Caution
@sumit-bose The patches did not apply cleanly. It is necessary to resolve conflicts before merging this pull request. Commits that introduced conflict are marked with
CONFLICT!.You can push changes to this pull request
Original commits
e83a29c - ldap: pwd_expire_policy_warn does not overwrite errors
57d6818 - test: pwd_expire_policy_warn does not overwrite errors (IPA)
1a258a4 - ldap: show expired message if shadow lastChange is missing or 0
aaaea88 - test: pwd_expire_policy_warn does not overwrite errors (LDAP)
Backported commits
Conflicting Files Information (check for deleted and re-added files)
On branch SSSD-sssd-backport-pr9393-to-sssd-2-9
You are currently cherry-picking commit aaaea88.
(fix conflicts and run "git cherry-pick --continue")
(use "git cherry-pick --skip" to skip this patch)
(use "git cherry-pick --abort" to cancel the cherry-pick operation)
Unmerged paths:
(use "git add ..." to mark resolution)
both modified: src/tests/system/tests/test_ldap.py
no changes added to commit (use "git add" and/or "git commit -a")