Repository navigation
Return proper tevent error in auth code - #9087
Draft
justin-stephenson wants to merge 6 commits into
Draft
justin-stephenson wants to merge 6 commits into
justin-stephenson wants to merge 6 commits into
Conversation
justin-stephenson
force-pushed
the
return_proper_tevent_error_in_auth
branch
from
August 17, 2026 19:49
c819b5e to
3c3a1b3
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
justin-stephenson
force-pushed
the
return_proper_tevent_error_in_auth
branch
4 times, most recently
from
August 18, 2026 15:07
125bb74 to
e8161a8
Compare
justin-stephenson
force-pushed
the
return_proper_tevent_error_in_auth
branch
11 times, most recently
from
October 7, 2026 13:19
411b87d to
19b931f
Compare
justin-stephenson
force-pushed
the
return_proper_tevent_error_in_auth
branch
from
October 23, 2026 18:55
19b931f to
c358803
Compare
justin-stephenson
force-pushed
the
return_proper_tevent_error_in_auth
branch
4 times, most recently
from
October 29, 2026 13:48
913ba45 to
3dcc9f2
Compare
In auth codepaths, return proper tevent req error in non-EOK/non-PAM_SUCCESS cases. Assisted-By: Claude Code (Opus 4.6)
When the backend returns non-EOK, the pam_status is lost therefore we need to do the conversion in the PAM responder.
Fix for test_smartcard__proxy_auth_uses_password_or_smartcard_based_on_local_auth_policy[smartcard_when_local_auth_policy_enables_it] In this test, pam_reply() checks for PAM_BAD_ITEM to follow the expected codepath. Return proper error code ERR_SC_AUTH_NOT_SUPPORTED which is converted to PAM_BAD_ITEM
"System error" is now present in the PAM logs but is unrelated, not tied to the offline authentication attempt.
Switch to use SSSD ERR_* errors only, these will be converted into the equivalent pam_status in pam_dp_req_send_done()
justin-stephenson
force-pushed
the
return_proper_tevent_error_in_auth
branch
from
October 29, 2026 18:35
3dcc9f2 to
54ad140
Compare
justin-stephenson
force-pushed
the
return_proper_tevent_error_in_auth
branch
from
October 30, 2026 16:35
d26a79f to
7d3abc7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.