Skip to content

utils/smartcard: add add_cert_key_by_path helper - #285

Merged
spoore1 merged 1 commit into
SSSD:masterfrom
krishnavema:smartcard-add-cert-key-by-path
Oct 13, 2026
Merged

spoore1 merged 1 commit into
SSSD:masterfrom
krishnavema:smartcard-add-cert-key-by-path

Conversation

@krishnavema

Copy link
Copy Markdown
Contributor

Combine initialize_card + add_key + add_cert, a pattern repeated across the AD, GDM and IPA smart card tests, into a single reusable method.

Comment thread sssd_test_framework/utils/smartcard.py
@krishnavema
krishnavema force-pushed the smartcard-add-cert-key-by-path branch from e2dbec3 to ff0d963 Compare October 12, 2026 13:33
Comment thread sssd_test_framework/utils/smartcard.py Outdated
@krishnavema
krishnavema force-pushed the smartcard-add-cert-key-by-path branch from ff0d963 to ad04681 Compare October 13, 2026 05:28

@sumit-bose sumit-bose left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

thanks for the updates, ACK.

CI failures are unrelated.

bye,
Sumit

Combine initialize_card + add_key + add_cert, a pattern repeated across the
AD, GDM and IPA smart card tests, into a single reusable method.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@krishnavema
krishnavema force-pushed the smartcard-add-cert-key-by-path branch from ad04681 to 66b28f2 Compare October 13, 2026 15:29

@spoore1 spoore1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

My only comment is that "source" seems vague but, not enough to request changes. Code looks good and is working in local tests.

@spoore1

spoore1 commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

Test failures not related to this new method being added:

FAILED tests/test_ipa.py::test_ipa__password_expiration_warning_does_not_overwrite_errors (ipa) - AssertionError: SSH was successful but should have failed!
assert 0 != 0
 +  where 0 = <pytest_mh.conn.ssh.SSHProcessResult object at 0x7f392ebd2850>.rc
FAILED tests/test_ldap.py::test_ldap__password_expiration_warning_does_not_overwrite_errors (ldap) - AssertionError: Missing 'Your password has expired.' in error output!
assert 'Your password has expired.' in "Warning: Permanently added 'localhost' (ED25519) to the list of known hosts.\r"
 +  where "Warning: Permanently added 'localhost' (ED25519) to the list of known hosts.\r" = <pytest_mh.conn.ssh.SSHProcessResult object at 0x7f392ed13a50>.stderr
FAILED tests/test_sudo.py::test_sudo__ldap_sudo_search_base_not_set_emits_warning (ldap) - AssertionError: Domain log must contain security warning when ldap_sudo_search_base is not set!

@spoore1
spoore1 merged commit 48ea76c into SSSD:master Oct 13, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants