Repository navigation
roles/ad: return (cert, key) consistently from AD CA request - #283
Merged
krishnavema merged 1 commit intoOct 13, 2026
Merged
Conversation
sumit-bose
approved these changes
Oct 12, 2026
sumit-bose
left a comment
sumit-bose
left a comment
Contributor
There was a problem hiding this comment.
Hi,
thank you for the patch, it is working as expected, ACK.
bye,
Sumit
The basic (no enrollment agent) path previously returned a PFX bundle, forcing test callers to know the internal PFX password and to map the certificate to the user themselves. Extract the key and map the cert via userCertificate inside request() so callers always get a (cert, key) pair. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
krishnavema
force-pushed
the
ad-ca-request-consistent-key
branch
from
October 13, 2026 08:37
31c6266 to
b210018
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basic (no enrollment agent) path previously returned a PFX bundle, forcing test callers to know the internal PFX password and to map the certificate to the user themselves. Extract the key and map the cert via userCertificate inside request() so callers always get a (cert, key) pair.