Repository navigation
Conversation
spoore1
previously approved these changes
Oct 6, 2026
spoore1
left a comment
spoore1
left a comment
Contributor
There was a problem hiding this comment.
LGTM. I ran it against AD locally and relevant tests pass:
tests/test_dyndns.py::test_dyndns__update_is_set_to_true (ad) PASSED [ 3%]
tests/test_dyndns.py::test_dyndns__update_is_set_to_false (ad) PASSED [ 7%]
tests/test_dyndns.py::test_dyndns__update_with_address_filtering[dyndns_iface = eth0] (ad) PASSED [ 11%]
tests/test_dyndns.py::test_dyndns__update_with_address_filtering[dyndns_iface = eth0, dummy0] (ad) PASSED [ 14%]
tests/test_dyndns.py::test_dyndns__update_configured_ttl_value (ad) PASSED [ 18%]
tests/test_dyndns.py::test_dyndns__update_over_tcp_only (ad) PASSED [ 22%]
tests/test_dyndns.py::test_dyndns__update_authentication_mechanism[dyndns_auth = None] (ad) PASSED [ 25%]
tests/test_dyndns.py::test_dyndns__update_authentication_mechanism[dyndns_auth = GSS-TSIG] (ad) PASSED [ 29%]
tests/test_dyndns.py::test_dyndns__update_does_not_contain_use_after_free_bugs (ad) PASSED [ 33%]
spoore1
self-requested a review
October 6, 2026 17:58
danlavu
force-pushed
the
fix/ad-dns-zone-activation-race
branch
from
October 6, 2026 17:58
57c2acd to
3314ec2
Compare
There is an undocumented hard coded 60 second limit that causes a race condition with freshly created zones. Verifies zone readiness via Resolve-DnsName (a real DNS protocol query) instead of Get-DnsServerResourceRecord (a management-API check), since the management API can report the zone as registered before the DNS service is actually answering authoritatively for it, which is what nsupdate relies on during its own SOA discovery. AI: Claude Sonnet 4.6 Co-authored-by: Cursor <cursoragent@cursor.com>
danlavu
force-pushed
the
fix/ad-dns-zone-activation-race
branch
from
October 6, 2026 18:21
3314ec2 to
f0aeb51
Compare
Contributor
Author
|
This isn't the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an undocumented hard coded 60 second limit that causes a race condition with freshly created zones.
AI: Claude Sonnet 4.6