UI fixes#69
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Fixed and refactored ui-issues concerning color, placement and no longer needed testing elements
Description
Refactored color management system, all colors can now be controlled centralized within color.kt. The offline test functionality was deleted, as there is no need for it anymore. UI element margins, placements & sizes are now refactored to be controllable mainly within ResponsiveDimensions.kt, so the need to search for placement & margin variable within the different screens is limited to a minimum. The placement has been improved but is not final, however changing things should be straightforward from now on.
Changes in the codebase:
Files created:
ResponsiveDimensions.kt
Files changed:
StartScreen, NavGraph, GameboardScreen, Theme, Color, Brush, UserNameScreen, StartScreen, SettingsScreen, LobbyScreen, JoinLobbyScreen, GameSettingsScreen, SettingsCornerButton, ResponsiveDimensions, AppButton