Fixed chat endpoints#110
Merged
Merged
Conversation
tasaje1
previously approved these changes
May 20, 2026
Collaborator
tasaje1
left a comment
tasaje1
left a comment
There was a problem hiding this comment.
als short term fix okay :)
| /** | ||
| * Verifies the sender's name, lobbyID, team and role sending a message to the operatives on the | ||
| * respective team. | ||
| * Verifies the sender's team and role and delegates message processing to @link ChatService. |
Collaborator
Author
There was a problem hiding this comment.
Ist geändert, danke :)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Unitl now, we had a verification implemented in the ChatController , that checked if the username was connected to a webSocket Session ID. However, the session ID management system is not yet fully in use, so I removed the verification, since it was throwing an exception because of a null username regardless of input.
Attention
This is a shortterm fix, we will add (better) verification back if we deem it needed during the next sprint. However, we chose to first see if the chat functionality overall is working, before we add verification and security mechanisms back.
Changes in the codebase
I removed the verification method (if we need it later, we can just go back to a commit and copy-paste it) and all of its calls.
I also updated the test cases and removed those tests, that specifically tested the removed method's functionality.
Changes outside the codebase
N/A
#Additional Information
N/A